* [PATCH] ARM: fix a wrong comment about relocate_to_adr
@ 2015-01-28 9:37 Masahiro Yamada
2015-01-29 6:55 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2015-01-28 9:37 UTC (permalink / raw)
To: barebox
The relocated_to_adr does not clear the .bss section.
It is done by the setup_c routine.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
arch/arm/cpu/setupc.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/setupc.S b/arch/arm/cpu/setupc.S
index 2df2683..c232b08 100644
--- a/arch/arm/cpu/setupc.S
+++ b/arch/arm/cpu/setupc.S
@@ -40,7 +40,7 @@ ENDPROC(setup_c)
/*
* void relocate_to_adr(unsigned long targetadr)
*
- * Copy binary to targetadr, relocate code, clear bss and continue
+ * Copy binary to targetadr, relocate code and continue
* executing at new address.
*/
.section .text.relocate_to_adr
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: fix a wrong comment about relocate_to_adr
2015-01-28 9:37 [PATCH] ARM: fix a wrong comment about relocate_to_adr Masahiro Yamada
@ 2015-01-29 6:55 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-01-29 6:55 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: barebox
On Wed, Jan 28, 2015 at 06:37:08PM +0900, Masahiro Yamada wrote:
> The relocated_to_adr does not clear the .bss section.
> It is done by the setup_c routine.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> arch/arm/cpu/setupc.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/arch/arm/cpu/setupc.S b/arch/arm/cpu/setupc.S
> index 2df2683..c232b08 100644
> --- a/arch/arm/cpu/setupc.S
> +++ b/arch/arm/cpu/setupc.S
> @@ -40,7 +40,7 @@ ENDPROC(setup_c)
> /*
> * void relocate_to_adr(unsigned long targetadr)
> *
> - * Copy binary to targetadr, relocate code, clear bss and continue
> + * Copy binary to targetadr, relocate code and continue
> * executing at new address.
> */
> .section .text.relocate_to_adr
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-28 9:37 [PATCH] ARM: fix a wrong comment about relocate_to_adr Masahiro Yamada
2015-01-29 6:55 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox