mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] blackfin: fix undefined reference with CONFIG_CMD_MAGICVAR
Date: Thu, 29 Jan 2015 10:07:01 +0100	[thread overview]
Message-ID: <20150129090701.GA12209@pengutronix.de> (raw)
In-Reply-To: <1422499872-3311-1-git-send-email-yamada.m@jp.panasonic.com>

On Thu, Jan 29, 2015 at 11:51:12AM +0900, Masahiro Yamada wrote:
> For Blackfin, C symbols are prefixed with '_'.
> 
> If CONFIG_CMD_MAGICVAR is enabled for Blackfin, the following error occurs:
> 
> commands/built-in.o: In function `do_magicvar':
> commands/magicvar.c:(.text+0x3326): undefined reference to `__barebox_magicvar_start'
> commands/magicvar.c:(.text+0x332a): undefined reference to `__barebox_magicvar_end'
> commands/magicvar.c:(.text+0x332e): undefined reference to `__barebox_magicvar_start'
> commands/magicvar.c:(.text+0x3332): undefined reference to `__barebox_magicvar_end'
> make: *** [barebox] Error 1
> 
> Add '_' to __barebox_magicvar_start and __barebox_magicvar_end,
> like the other symbols in this linker script.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-01-29  9:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29  2:51 Masahiro Yamada
2015-01-29  9:07 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129090701.GA12209@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=yamada.m@jp.panasonic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox