From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] watchdog: imx: error out on negative timeouts
Date: Mon, 2 Feb 2015 11:49:57 +0100 [thread overview]
Message-ID: <20150202104957.GA10842@pengutronix.de> (raw)
In-Reply-To: <1422366061-26735-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hello,
On Tue, Jan 27, 2015 at 02:41:01PM +0100, Uwe Kleine-König wrote:
> I'm not sure where a negative timeout could come from but making the
> code more robust for no additional runtime cost is good nevertheless.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/watchdog/imxwd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/imxwd.c b/drivers/watchdog/imxwd.c
> index 31c3d0d85353..66e9f6848f74 100644
> --- a/drivers/watchdog/imxwd.c
> +++ b/drivers/watchdog/imxwd.c
> @@ -87,7 +87,7 @@ static int imx21_watchdog_set_timeout(struct imx_wd *priv, int timeout)
>
> dev_dbg(priv->dev, "%s: %d\n", __func__, timeout);
>
> - if (!timeout || timeout > 128)
> + if (timeout <= 0 || timeout > 128)
> return -EINVAL;
This patch is broken because reset_cpu (in the same source file) calls
set_timeout with timeout=-1 to reset the cpu immediatly. The wd command
only parses non-negative values, so from there nothing strange should be
expected.
Returning -EINVAL on timeout=0 (which means "disable watchdog") is OK
because the imx21 watchdog cannot be stopped.
So in short: please drop this patch from next.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-02-02 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 13:41 Uwe Kleine-König
2015-01-28 9:15 ` Sascha Hauer
2015-02-02 10:49 ` Uwe Kleine-König [this message]
2015-02-02 11:04 ` Sascha Hauer
2015-02-02 11:50 ` Masahiro Yamada
2015-02-02 12:16 ` Sascha Hauer
2015-02-03 6:14 ` Masahiro Yamada
2015-02-03 7:44 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202104957.GA10842@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox