From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/3] mtd: nand: ONFI probing for x16 devices on i.MX25 (and others)
Date: Mon, 9 Feb 2015 08:11:26 +0100 [thread overview]
Message-ID: <20150209071126.GQ12209@pengutronix.de> (raw)
In-Reply-To: <1423171292-26728-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Thu, Feb 05, 2015 at 10:21:29PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> On an i.MX25 based machine barebox issued a warning during startup:
>
> nand: Trying ONFI probe in 16 bits mode, aborting !
>
> without much side effects as the NAND chip was detected correctly nevertheless.
>
> On the quest to fix this warning I noticed that there isn't much justification
> to not probe via ONFI even in x16 mode in the presence of the read_byte
> callback that is correctly used in the ONFI detection code. But removing this
> early exit in the generic probe routines brought to light that the imx nand
> driver didn't implement this read_byte callback correctly.
>
> This series first fixes the imx nand driver to implement the read_byte callback
> correctly and then "fixes" the ONFI code to try detection even in x16 mode.
> This made the above mentioned warning go away and print
>
> nand: ONFI flash detected
>
> instead \o/. The generic code change was mostly cherry-picked from Linux, so I
> kept the original author annotation here.
>
> As an added bonus there is a little optimisation at the end of the series.
>
> Best regards
> Uwe
>
> Brian Norris (1):
> mtd: nand: cleanup ONFI printed errors, warnings
>
> Uwe Kleine-König (2):
> mtd: nand-imx: fix byte reading in x16 mode
> mtd: nand-imx: don't copy more bytes than read from hardware
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-02-09 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 21:21 Uwe Kleine-König
2015-02-05 21:21 ` [PATCH 1/3] mtd: nand-imx: fix byte reading in x16 mode Uwe Kleine-König
2015-02-05 21:21 ` [PATCH 2/3] mtd: nand: cleanup ONFI printed errors, warnings Uwe Kleine-König
2015-02-05 21:21 ` [PATCH 3/3] mtd: nand-imx: don't copy more bytes than read from hardware Uwe Kleine-König
2015-02-09 7:11 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150209071126.GQ12209@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox