mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* bareboxenv: console bootargs
@ 2015-02-20  8:00 Teresa Gámez
  2015-02-23  8:01 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Teresa Gámez @ 2015-02-20  8:00 UTC (permalink / raw)
  To: barebox

Hello,

I have noticed that the console= bootarg parameter in the latest
enviroment is set in the /env/nv/linux.bootargs.base variable. But it is
also set over common/console.c in the variable linux.bootargs.console
which results here in two console= parameter:

commandline: console=ttyO0,115200n8 console=ttyO0,115200
root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait

Wouldn't it be the right way to set the linux.bootargs.console instead
of the linux.bootargs.base in the enviroment. If it needs to be
overwritten at all...

I suspect that other boards, then the am335x ones, are also affected.

Regards
Teresa




_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: bareboxenv: console bootargs
  2015-02-20  8:00 bareboxenv: console bootargs Teresa Gámez
@ 2015-02-23  8:01 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2015-02-23  8:01 UTC (permalink / raw)
  To: Teresa Gámez; +Cc: barebox

Hi Teresa,

On Fri, Feb 20, 2015 at 09:00:20AM +0100, Teresa Gámez wrote:
> Hello,
> 
> I have noticed that the console= bootarg parameter in the latest
> enviroment is set in the /env/nv/linux.bootargs.base variable. But it is
> also set over common/console.c in the variable linux.bootargs.console
> which results here in two console= parameter:
> 
> commandline: console=ttyO0,115200n8 console=ttyO0,115200
> root=/dev/mmcblk0p2 rootfstype=ext4 rw rootwait
> 
> Wouldn't it be the right way to set the linux.bootargs.console instead
> of the linux.bootargs.base in the enviroment. If it needs to be
> overwritten at all...

Indeed, linux.bootargs.console would be a better variable for the
console bootargs. The OMAP and i.MX boards don't need this setting
because they set it in common/console.c using the linux_console_name
variable. I just sent a patch to fix that.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-23  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20  8:00 bareboxenv: console bootargs Teresa Gámez
2015-02-23  8:01 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox