mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] scripts: socfpga: statify sys_mgr_init_table
@ 2015-03-05 10:58 Steffen Trumtrar
  2015-03-05 10:58 ` [PATCH 2/2] ARM: socfpga: socdk: " Steffen Trumtrar
  2015-03-06  6:43 ` [PATCH 1/2] scripts: socfpga: " Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Steffen Trumtrar @ 2015-03-05 10:58 UTC (permalink / raw)
  To: barebox; +Cc: Steffen Trumtrar

The preloader import-script misses the sys_mgr_init_table variable.
When multiple boards are build, this will lead to compile errors,
because the variable exists multiple times.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 scripts/socfpga_import_preloader | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/socfpga_import_preloader b/scripts/socfpga_import_preloader
index 9fc657e483e6..b08262cb6c83 100755
--- a/scripts/socfpga_import_preloader
+++ b/scripts/socfpga_import_preloader
@@ -29,6 +29,7 @@ copy_source() {
 	echo "	Fixing extern/static keywords..."
 	# Statify all global variables with missing static keyword
 	sed -i 's/^const /static const /g' $tgt
+	sed -i 's/^unsigned long sys_mgr_init_table/static unsigned long sys_mgr_init_table/g' $tgt
 
 	echo "	Remove unused defines..."
 	sed -i 's/\[CONFIG_HPS_PINMUX_NUM\]/\[\]/g' $tgt
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: socfpga: socdk: statify sys_mgr_init_table
  2015-03-05 10:58 [PATCH 1/2] scripts: socfpga: statify sys_mgr_init_table Steffen Trumtrar
@ 2015-03-05 10:58 ` Steffen Trumtrar
  2015-03-06  6:43 ` [PATCH 1/2] scripts: socfpga: " Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Steffen Trumtrar @ 2015-03-05 10:58 UTC (permalink / raw)
  To: barebox; +Cc: Steffen Trumtrar

The socdk can't be build in a multiboard environment, i.e. when other
socfgpa boards are also build.

Fix this.

Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
 arch/arm/boards/altera-socdk/pinmux_config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boards/altera-socdk/pinmux_config.c b/arch/arm/boards/altera-socdk/pinmux_config.c
index 0965e133792f..ff784bbecf93 100644
--- a/arch/arm/boards/altera-socdk/pinmux_config.c
+++ b/arch/arm/boards/altera-socdk/pinmux_config.c
@@ -30,7 +30,7 @@
 #include <common.h>
 
 /* pin MUX configuration data */
-unsigned long sys_mgr_init_table[] = {
+static unsigned long sys_mgr_init_table[] = {
 	0,			/* EMACIO0 */
 	2,			/* EMACIO1 */
 	2,			/* EMACIO2 */
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] scripts: socfpga: statify sys_mgr_init_table
  2015-03-05 10:58 [PATCH 1/2] scripts: socfpga: statify sys_mgr_init_table Steffen Trumtrar
  2015-03-05 10:58 ` [PATCH 2/2] ARM: socfpga: socdk: " Steffen Trumtrar
@ 2015-03-06  6:43 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2015-03-06  6:43 UTC (permalink / raw)
  To: Steffen Trumtrar; +Cc: barebox

On Thu, Mar 05, 2015 at 11:58:30AM +0100, Steffen Trumtrar wrote:
> The preloader import-script misses the sys_mgr_init_table variable.
> When multiple boards are build, this will lead to compile errors,
> because the variable exists multiple times.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  scripts/socfpga_import_preloader | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-03-06  6:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-05 10:58 [PATCH 1/2] scripts: socfpga: statify sys_mgr_init_table Steffen Trumtrar
2015-03-05 10:58 ` [PATCH 2/2] ARM: socfpga: socdk: " Steffen Trumtrar
2015-03-06  6:43 ` [PATCH 1/2] scripts: socfpga: " Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox