From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <dev@lynxeye.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] images: move board variable to parent makefile
Date: Mon, 9 Mar 2015 11:53:21 +0100 [thread overview]
Message-ID: <20150309105321.GF31289@pengutronix.de> (raw)
In-Reply-To: <1425673322-31946-1-git-send-email-dev@lynxeye.de>
On Fri, Mar 06, 2015 at 09:22:01PM +0100, Lucas Stach wrote:
> A lot of the image makefiles define an equal board variable, which
> gives the impression that this variable is unique for this makefile.
> As those files aren't freestanding makefiles but get included into a
> parent makefile this is not actually true. Attempts to override this
> variable will not work reliable as make is picking up a random instance.
>
> Fix this confusion by moving this variable out of the individual makefiles.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
> images/Makefile | 2 ++
> images/Makefile.imx | 2 --
> images/Makefile.mvebu | 2 --
> images/Makefile.mxs | 1 -
> images/Makefile.rockchip | 2 --
> images/Makefile.tegra | 2 --
> 6 files changed, 2 insertions(+), 9 deletions(-)
Applied, thanks
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-03-09 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 20:22 Lucas Stach
2015-03-06 20:22 ` [PATCH 2/2] images: fix Tegra out-of-tree build Lucas Stach
2015-03-09 10:53 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309105321.GF31289@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox