From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 7/8] digest: add HMAC support for md5, sha1, sha224, sha256, sha384, sha512
Date: Thu, 12 Mar 2015 09:13:08 +0100 [thread overview]
Message-ID: <20150312081308.GR30554@ns203013.ovh.net> (raw)
In-Reply-To: <20150312071707.GZ24885@pengutronix.de>
On 08:17 Thu 12 Mar , Sascha Hauer wrote:
> On Wed, Mar 11, 2015 at 05:53:08PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > the hmac algo will be registered as hmac(%s) such as hmac(sha256)
> >
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> > +static int digest_hmac_alloc(struct digest *d)
> > +{
> > + struct digest_hmac_ctx *dh = d->ctx;
> > + struct digest_hmac *hmac = to_digest_hmac(d->algo);
> > +
> > + dh->d = digest_alloc(hmac->name);
> > + if (!dh->d)
> > + return -EINVAL;
> > +
> > + dh->ipad = xmalloc(sizeof(unsigned char) * hmac->pad_length);
> > + dh->opad = xmalloc(sizeof(unsigned char) * hmac->pad_length);
>
> sizeof(unsigned char) is 1. Dropped while applying.
habit to always use sizeof but yes no diff
Best Regards,
J.
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-03-12 8:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 16:50 [PATCH 0/8 v3] add sha384/sha512 and hmac support Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 1/8] digest: move digest.c to crypto Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 2/8] digest: introduce digest_{init/update/final/length} Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 3/8] digest: make it multi-instance Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 4/8] crypto: add sha384 & sha512 support Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 5/8] command: add sha384sum and sha512sum support Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 6/8] password: add support for sha512 Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 16:53 ` [PATCH 7/8] digest: add HMAC support for md5, sha1, sha224, sha256, sha384, sha512 Jean-Christophe PLAGNIOL-VILLARD
2015-03-12 7:17 ` Sascha Hauer
2015-03-12 8:13 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-03-11 16:53 ` [PATCH 8/8] command: add hmac sum supportfor " Jean-Christophe PLAGNIOL-VILLARD
2015-03-16 11:01 ` Jan Lübbe
2015-03-16 11:27 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-16 12:52 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2015-03-11 13:26 [PATCH 0/8] add sha384/sha512 and hmac support Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 13:41 ` [PATCH 1/8] digest: move digest.c to crypto Jean-Christophe PLAGNIOL-VILLARD
2015-03-11 13:41 ` [PATCH 7/8] digest: add HMAC support for md5, sha1, sha224, sha256, sha384, sha512 Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312081308.GR30554@ns203013.ovh.net \
--to=plagnioj@jcrosoft.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox