mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 1/7] pci: Use standard pr_debug
Date: Wed, 18 Mar 2015 10:08:53 +0100	[thread overview]
Message-ID: <20150318090853.GS26127@ns203013.ovh.net> (raw)
In-Reply-To: <1426574331-22797-2-git-send-email-s.hauer@pengutronix.de>

On 07:38 Tue 17 Mar     , Sascha Hauer wrote:
> Use pr_debug instead of custom DBG macro.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/pci/pci.c | 34 +++++++++++++++-------------------
>  1 file changed, 15 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 1f5dc78..cb8c539 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -1,13 +1,9 @@
> +#define pr_fmt(fmt)  "pci: " fmt
> +
>  #include <common.h>
>  #include <linux/sizes.h>
>  #include <linux/pci.h>
>  
> -#ifdef DEBUG
> -#define DBG(x...) printk(x)
> -#else
> -#define DBG(x...)
> -#endif
> -
>  static struct pci_controller *hose_head, **hose_tail = &hose_head;
>  
>  LIST_HEAD(pci_root_buses);
> @@ -150,16 +146,16 @@ static void setup_device(struct pci_dev *dev, int max_bar)
>  		pci_read_config_dword(dev, PCI_BASE_ADDRESS_0 + bar * 4, &mask);
>  
>  		if (mask == 0 || mask == 0xffffffff) {
> -			DBG("  PCI: pbar%d set bad mask\n", bar);
> +			pr_debug("pbar%d set bad mask\n", bar);
dev_debug

please

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-03-18  9:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17  6:38 i.MX6 PCI support Sascha Hauer
2015-03-17  6:38 ` [PATCH 1/7] pci: Use standard pr_debug Sascha Hauer
2015-03-18  9:08   ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2015-03-17  6:38 ` [PATCH 2/7] pci: fix copy-paste bug Sascha Hauer
2015-03-17  6:38 ` [PATCH 3/7] pci: pci_regs.h: Sync with Linux Sascha Hauer
2015-03-17  6:38 ` [PATCH 4/7] pci: Add pcie-designware driver Sascha Hauer
2015-03-17  6:38 ` [PATCH 5/7] ARM: i.MX: Add imx_clk_gate_exclusive Sascha Hauer
2015-03-17  6:38 ` [PATCH 6/7] ARM: i.MX6: Add PCI clocks Sascha Hauer
2015-03-17  6:38 ` [PATCH 7/7] pci: Add i.MX6 pcie support Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150318090853.GS26127@ns203013.ovh.net \
    --to=plagnioj@jcrosoft.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox