From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Gabor Janak (g.janak@agilion.de)" <g.janak@agilion.de>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: OMAP NAND Driver ECC Read broken
Date: Fri, 27 Mar 2015 08:52:09 +0100 [thread overview]
Message-ID: <20150327075209.GT9742@pengutronix.de> (raw)
In-Reply-To: <DB3PR03MB0826EDA17C8F26BA05AEAC9A98080@DB3PR03MB0826.eurprd03.prod.outlook.com>
Hi Gabor,
On Thu, Mar 26, 2015 at 08:13:38AM +0000, Gabor Janak (g.janak@agilion.de) wrote:
> Hello,
>
> on all Platforms which using
> drivers/mtd/nand/nand_omap_gpmc.c
> with ECC Mode OMAP_ECC_HAMMING_CODE_HW_ROMCODE
> (in DTS: bch8_hw_romcode ) the Code is only check the first part of a block page.
>
> The special Read-function read always a whole page, but only the ECC results oft he first block is checked.
> Any Error after first 512Byte are not detected and not corrected.
>
> I'm Using barebox-2014.09 on am335x . But it looks in the current HEAD same ...
>
> A fast Workaround hack :
> In function omap_correct_bch:
> Settings blocks always to 4 and because eccsize is 13
>
> Changing at the end:
> calc_ecc = calc_ecc + eccsize;
> read_ecc = read_ecc + eccsize+1; //add 1 because in Flash 13+1 is written
> dat += 512;
>
>
> I know this ist he wrong way.... ;)
>
> If i have some time, i will try to search a better solution, but currently i have not much time.
It would be great if you could find the time to write a patch. Thanks
for noting this issue anyway, it may safe other peoples time.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-03-27 7:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 8:13 Gabor Janak (g.janak@agilion.de)
2015-03-27 7:52 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327075209.GT9742@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=g.janak@agilion.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox