From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: RFC: of_device_id: use pointer for the data field
Date: Mon, 27 Apr 2015 08:00:59 +0200 [thread overview]
Message-ID: <20150427060059.GV6325@pengutronix.de> (raw)
In-Reply-To: <20150426173831.c6246f01a64d316351f3ce54@gmail.com>
On Sun, Apr 26, 2015 at 05:38:31PM +0300, Antony Pavlov wrote:
> Hi!
>
> Just now barebox' of_device_id struct uses unsigned long type for data field:
>
> struct of_device_id {
> char *compatible;
> unsigned long data;
> };
>
> Here is of_device_id struct in linux kernel:
>
> struct of_device_id {
> char name[32];
> char type[32];
> char compatible[128];
> const void *data;
> };
>
> Just all data fields are used as pointers and need 'unsigned long' casting.
> E.g. see 'git grep -A 4 of_device_id drivers/' output:
>
> drivers/ata/sata-imx.c:static __maybe_unused struct of_device_id imx_sata_dt_ids[] = {
> drivers/ata/sata-imx.c- {
> drivers/ata/sata-imx.c- .compatible = "fsl,imx6q-ahci",
> drivers/ata/sata-imx.c- .data = (unsigned long)&data_imx6,
> drivers/ata/sata-imx.c- }, {
>
> Could we use 'const void *' type for data field as linux kernel does?
Yes, good idea.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-04-27 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 14:38 Antony Pavlov
2015-04-27 6:00 ` Sascha Hauer [this message]
2015-04-27 9:17 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427060059.GV6325@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox