From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Yt880-0002MA-8B for barebox@lists.infradead.org; Fri, 15 May 2015 05:25:44 +0000 Date: Fri, 15 May 2015 07:25:21 +0200 From: Sascha Hauer Message-ID: <20150515052521.GI6325@pengutronix.de> References: <1431572067-4038-1-git-send-email-andrew.smirnov@gmail.com> <1431572067-4038-6-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1431572067-4038-6-git-send-email-andrew.smirnov@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 06/10] common: pbl: Allow boards to override hang() To: Andrey Smirnov Cc: barebox@lists.infradead.org Hi Andrey, On Wed, May 13, 2015 at 07:54:23PM -0700, Andrey Smirnov wrote: > Add provisions such that board code can re-define the behaviour of > hang() to implement a behaviour better suited for a particular > hardware platform. I'm generally fine with being able to overwrite hang(), but the ARM specific changes here should be an extra patch with an explanation why this change is necessary. I assume you want to make hang() usable for early debugging in the PBL when the code is not running at the address it's linked at. But that's only an assumption. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox