From: Antony Pavlov <antonynpavlov@gmail.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] include: introduce include/linux/io.h as a wrapper of asm/io.h
Date: Sun, 17 May 2015 18:47:04 +0300 [thread overview]
Message-ID: <20150517184704.9b64228117f4a3addf0f4f12@gmail.com> (raw)
In-Reply-To: <1431694967-2416-1-git-send-email-yamada.masahiro@socionext.com>
On Fri, 15 May 2015 22:02:47 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> In the latest Linux coding style, <linux/io.h> should be included
> rather than <asm/io.h>. To follow this standard also in barebox,
> add include/linux/io.h. Currently, it just includes <asm/io.h>.
Hmmm. Barebox already has include/io.h for the same purpose.
And include/io.h is actively used:
~/barebox.git$ git grep "include <io.h>" | wc -l
474
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Changes in v2:
> - Fix a type s/introcude/introduce/
>
> include/linux/io.h | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 include/linux/io.h
>
> diff --git a/include/linux/io.h b/include/linux/io.h
> new file mode 100644
> index 0000000..548b245
> --- /dev/null
> +++ b/include/linux/io.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright 2006 PathScale, Inc. All Rights Reserved.
> + *
> + * This file is free software; you can redistribute it and/or modify
> + * it under the terms of version 2 of the GNU General Public License
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software Foundation,
> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
> + */
> +
> +#ifndef _LINUX_IO_H
> +#define _LINUX_IO_H
> +
> +#include <asm/io.h>
> +
> +#endif /* _LINUX_IO_H */
> --
> 1.9.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-05-17 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 13:02 Masahiro Yamada
2015-05-17 15:47 ` Antony Pavlov [this message]
2015-05-18 1:48 ` Masahiro Yamada
2015-05-18 12:29 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517184704.9b64228117f4a3addf0f4f12@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox