From: Sascha Hauer <s.hauer@pengutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] include: introduce include/linux/io.h as a wrapper of asm/io.h
Date: Mon, 18 May 2015 14:29:50 +0200 [thread overview]
Message-ID: <20150518122950.GT6325@pengutronix.de> (raw)
In-Reply-To: <CAK7LNATTasdDYvzHxu=F8Jcmgh8v3nAQOvrJsrmN0moDDLh6Gw@mail.gmail.com>
On Mon, May 18, 2015 at 10:48:30AM +0900, Masahiro Yamada wrote:
> 2015-05-18 0:47 GMT+09:00 Antony Pavlov <antonynpavlov@gmail.com>:
> > On Fri, 15 May 2015 22:02:47 +0900
> > Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> >
> >> In the latest Linux coding style, <linux/io.h> should be included
> >> rather than <asm/io.h>. To follow this standard also in barebox,
> >> add include/linux/io.h. Currently, it just includes <asm/io.h>.
> >
> > Hmmm. Barebox already has include/io.h for the same purpose.
> > And include/io.h is actively used:
> >
> > ~/barebox.git$ git grep "include <io.h>" | wc -l
> > 474
> >
>
> We can replace all of them with sed easily.
I'm with Antony here. I think we can afford our own version of <io.h>.
>
> Moreover, cpu_read{b,w,l} and cpu_write{b,w,l} turned out unnecessary after all.
> Most of C sources use __raw_*.
Agreed, these could be removed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-05-18 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 13:02 Masahiro Yamada
2015-05-17 15:47 ` Antony Pavlov
2015-05-18 1:48 ` Masahiro Yamada
2015-05-18 12:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518122950.GT6325@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox