From: Sascha Hauer <s.hauer@pengutronix.de>
To: Stefan Christ <s.christ@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] barebox update: add note after successful update
Date: Fri, 22 May 2015 08:50:37 +0200 [thread overview]
Message-ID: <20150522065037.GT6325@pengutronix.de> (raw)
In-Reply-To: <1432194109-4340-1-git-send-email-s.christ@phytec.de>
On Thu, May 21, 2015 at 09:41:49AM +0200, Stefan Christ wrote:
> Some users of the barebox_update command forget to erase the external
> barebox environment after updating the barebox. Using an old barebox
> environment leads to various problems if there were major changes.
>
> So add a gentle reminder after the successful update.
>
> Signed-off-by: Stefan Christ <s.christ@phytec.de>
> ---
> common/bbu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/common/bbu.c b/common/bbu.c
> index 7fb154a..1b125e9 100644
> --- a/common/bbu.c
> +++ b/common/bbu.c
> @@ -113,8 +113,11 @@ int barebox_update(struct bbu_data *data)
> if (ret == -EINTR)
> printf("update aborted\n");
>
> - if (!ret)
> + if (!ret) {
> printf("update succeeded\n");
> + if (IS_ENABLED(CONFIG_ENV_HANDLING))
> + printf("You maybe want to erase the barebox environment.\n");
How about adding a hint ...using saveenv -z?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2015-05-22 6:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 7:41 Stefan Christ
2015-05-22 6:50 ` Sascha Hauer [this message]
2015-05-22 11:55 ` Stefan Christ
2015-05-29 7:22 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522065037.GT6325@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.christ@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox