From: Sascha Hauer <s.hauer@pengutronix.de>
To: Wadim Egorov <w.egorov@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: Add an am33xx include file for MLO size reduction
Date: Tue, 26 May 2015 08:16:45 +0200 [thread overview]
Message-ID: <20150526061645.GX6325@pengutronix.de> (raw)
In-Reply-To: <1432296555-48594-1-git-send-email-w.egorov@phytec.de>
On Fri, May 22, 2015 at 02:09:14PM +0200, Wadim Egorov wrote:
> AM335x's MLO size limit is 109K.
> The am33xx.dtsi file adds spare and never used nodes to the dtb.
> With this patch we add a file to remove the unused nodes and reduce the
> size of the dtb.
>
> Including this file will reduce the lzo packed MLO size about 8K.
>
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> arch/arm/dts/strip-am33xx.dtsi | 66 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 arch/arm/dts/strip-am33xx.dtsi
>
> diff --git a/arch/arm/dts/strip-am33xx.dtsi b/arch/arm/dts/strip-am33xx.dtsi
You remove the UARTs not used on *Phytec* boards, they could well be
used on other boards. While I agree for the CAN nodes and many others,
UARTs should be kept. Also the GPIOs can be very useful in the MLO. I
suggest that you either change the name of this file to something less
generic (am33xx-phytec-strip.dtsi) or you make a generic more generic
file and remove the unused UARTs / GPIOs in the board specific dts file.
Whatever you do, please keep the am33xx- at the beginning of the
filename.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-05-26 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 12:09 Wadim Egorov
2015-05-22 12:09 ` [PATCH 2/2] ARM: dts: Add strip-am33xx.dtsi to PHYTEC MLOs Wadim Egorov
2015-05-26 6:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526061645.GX6325@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox