[PATCH] dhcp: add missing define

[PATCH] dhcp: add missing define

[Robert Schwebel]

Without this, we get

commands/dhcp.c: In function 'do_dhcp':
commands/dhcp.c:22:16: error: 'DHCP_DEFAULT_RETRY' undeclared (first use in this function)
  int retries = DHCP_DEFAULT_RETRY;
                ^
commands/dhcp.c:22:16: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:249: recipe for target 'commands/dhcp.o' failed

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
---
 commands/dhcp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/commands/dhcp.c b/commands/dhcp.c
index eb98bfc..0358a4c 100644
--- a/commands/dhcp.c
+++ b/commands/dhcp.c
@@ -16,6 +16,8 @@
 #include <getopt.h>
 #include <dhcp.h>
 
+#define DHCP_DEFAULT_RETRY 20
+
 static int do_dhcp(int argc, char *argv[])
 {
 	int ret, opt;
-- 
2.1.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] dhcp: add missing define

[Robert Schwebel]

Hi,

I think this was somehow missing in 32900eaf7c95e52da33442b24ce91c747e700cff
and this patch should be squashed into the patch above in next.

rsc

On Tue, Jun 02, 2015 at 08:04:37PM +0200, Robert Schwebel wrote:
> Without this, we get
> 
> commands/dhcp.c: In function 'do_dhcp':
> commands/dhcp.c:22:16: error: 'DHCP_DEFAULT_RETRY' undeclared (first use in this function)
>   int retries = DHCP_DEFAULT_RETRY;
>                 ^
> commands/dhcp.c:22:16: note: each undeclared identifier is reported only once for each function it appears in
> scripts/Makefile.build:249: recipe for target 'commands/dhcp.o' failed
> 
> Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>
> ---
>  commands/dhcp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/commands/dhcp.c b/commands/dhcp.c
> index eb98bfc..0358a4c 100644
> --- a/commands/dhcp.c
> +++ b/commands/dhcp.c
> @@ -16,6 +16,8 @@
>  #include <getopt.h>
>  #include <dhcp.h>
>  
> +#define DHCP_DEFAULT_RETRY 20
> +
>  static int do_dhcp(int argc, char *argv[])
>  {
>  	int ret, opt;
> -- 
> 2.1.4



-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] dhcp: add missing define

[Sascha Hauer]

On Tue, Jun 02, 2015 at 08:06:44PM +0200, Robert Schwebel wrote:
> Hi,
> 
> I think this was somehow missing in 32900eaf7c95e52da33442b24ce91c747e700cff
> and this patch should be squashed into the patch above in next.

This is not the only problem with this patch. I have dropped it, see my
reply to that patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox