Re: barebox picotcp integration (2015.06.14)

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Jun 15, 2015 at 01:13:43AM +0300, Antony Pavlov wrote:
> Hi!
> 
> I have just published latest picotcp-enabled barebox.
> Please see my 20150614.picotcp branch in my github barebox repo
> (https://github.com/frantony/barebox/tree/20150614.picotcp).
> 
> This version is based on latest barebox-next and latest picotcp-development.
> Here is barebox picotcp network features:
> 
>        * network interfaces and the 'ifconfig' command to rule them;
>        * the 'route' command to see current picotcp route table;
>        * the 'picoping' command to use picotcp ping support (also now barebox responds
>          to ping requests);
>        * the 'dhclient' command to use picotcp dhcp client;
>        * picotcp-based tftp filesystem support.
> 
> Changes since 2015.03.31:
> 
>        * split patches (ifconfig, route, picoping and dhclient commands
>          are introduced in separate patches now);
>        * rework picotcp Kconfig stuff;
>        * fix formatting.
> 
> Here is note/todo list:
> 
>   1. tftp write operation is not supported;

Why are you using the picotcp tftp implementation? picotcp surely
supports sending/receiving udp packets, right? Wouldn't it be a good
first step to replace the barebox udp API with the one picotcp provides?
I mean I would expect that you replace only the network stack, not the
network stack including the applications. If at some point we decide
that the tftp implementation in picotcp is better than the one in
barebox that would be the time to switch it.

> 
>   2. with picotcp we can't easely use 'tftp' command with old syntax
>      (no $<current ethernet>.serverip anymore);
> 
>   3. just now picotcp-based tftp file transfer is 5 times slower than
>      old realisation (partialy it is my bad, e.g. extra memory copy operation
>      is used for code simplification);

An additional memcpy shouldn't make tftp 5 times slower. There must be
something else.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox