mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 3/6] System restart: add a scope value to the system restart feature
Date: Thu, 25 Jun 2015 09:06:05 +0200	[thread overview]
Message-ID: <201506250906.06141.jbe@pengutronix.de> (raw)
In-Reply-To: <20150624183440.GT26575@pengutronix.de>

Hi Sascha,

On Wednesday 24 June 2015 20:34:40 Sascha Hauer wrote:
> On Mon, Jun 22, 2015 at 12:33:21PM +0200, Juergen Borleis wrote:
> > Some systems have more than one feature to restart it. Maybe these
> > restarts features are all equal or it is very important which restart
> > feauture is used to restart the system in a reliable manner. For example
> > if external devices must be reset in conjunction with the SoC some SoC's
> > internal restart features cannot be used. Then an external restart
> > feature must be forced instead by using the restart feature with the
> > wider scope.
>
> It seems this patch misses several conversions from reset_cpu to
> restart_machine:
>
> ./arch/mips/lib/bootm.c:23:     reset_cpu(0);
> ./arch/ppc/lib/ppclinux.c:90:   reset_cpu(0);
> ./arch/sandbox/os/common.c:144:                 reset_cpu(0);
> ./arch/sandbox/os/common.c:152:                 reset_cpu(0);
> ./arch/arm/mach-at91/bootstrap.c:148:   reset_cpu(0);
> ./arch/arm/mach-tegra/tegra20-pmc.c:221:        reset_cpu(0);
> ./arch/blackfin/lib/traps.c:94: reset_cpu(0);
> ./arch/blackfin/lib/traps.c:104:        reset_cpu(0);

Hmm, interesting. I did a sed replacement in the whole source tree. Don't know 
why they slipped through.

> ./arch/arm/mach-at91/at91sam9g45_reset.S
> ./arch/arm/mach-at91/at91sam9_reset.S

Ups, assembler...

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-06-25  7:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-22 10:33 [PATCH] Change barebox regarding "machine-restart", "reset cause detection" und "watchdog usage" Juergen Borleis
2015-06-22 10:33 ` [PATCH 1/6] Common: define scopes a specific hardware or software feature can cope with Juergen Borleis
2015-06-22 10:33 ` [PATCH 2/6] Reset reason: add a scope value to the reset reason feature Juergen Borleis
2015-06-22 10:33 ` [PATCH 3/6] System restart: add a scope value to the system restart feature Juergen Borleis
2015-06-24 18:34   ` Sascha Hauer
2015-06-25  7:06     ` Juergen Borleis [this message]
2015-06-22 10:33 ` [PATCH 4/6] Watchdog: add a scope value to the watchdog feature Juergen Borleis
2015-06-22 10:33 ` [PATCH 5/6] Watchdog/i.MX: make the watchdog driver a regular driver Juergen Borleis
2015-06-22 10:33 ` [PATCH 6/6] MFD/DA9053: da9053: add basic da9053 driver Juergen Borleis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201506250906.06141.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox