mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Daniel Schultz <d.schultz@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] include: mci: Add new ext. CSD field defines
Date: Tue, 25 Aug 2015 07:50:40 +0200	[thread overview]
Message-ID: <20150825055040.GM18700@pengutronix.de> (raw)
In-Reply-To: <1440415935-32674-3-git-send-email-d.schultz@phytec.de>

On Mon, Aug 24, 2015 at 01:32:15PM +0200, Daniel Schultz wrote:
> Added missing defines for the extended CSD register until standard 5.1.
> 
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
>  include/mci.h | 188 ++++++++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 143 insertions(+), 45 deletions(-)
> 
> diff --git a/include/mci.h b/include/mci.h
> index a7bf8cd..dfeca46 100644
> --- a/include/mci.h
> +++ b/include/mci.h
> @@ -137,51 +137,149 @@
>   * EXT_CSD fields
>   */
>  
> -#define EXT_CSD_FLUSH_CACHE		32      /* W */
> -#define EXT_CSD_CACHE_CTRL		33      /* R/W */
> -#define EXT_CSD_POWER_OFF_NOTIFICATION	34	/* R/W */
> -#define EXT_CSD_GP_SIZE_MULT		143	/* R/W */

Please do not change the whitespaces in existing defines. Better some
whitespaces inconstistencies but a better to review patch.

Also you are using some of the defines in 1/3, so this patch should be
before it, right?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2015-08-25  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 11:32 [PATCH 1/3] commands: Add MMC ext. CSD register tool Daniel Schultz
2015-08-24 11:32 ` [PATCH 2/3] drivers: mci: Make two functions public Daniel Schultz
2015-08-25  5:51   ` Sascha Hauer
2015-08-24 11:32 ` [PATCH 3/3] include: mci: Add new ext. CSD field defines Daniel Schultz
2015-08-25  5:50   ` Sascha Hauer [this message]
2015-08-25  7:06 ` [PATCH 1/3] commands: Add MMC ext. CSD register tool Sascha Hauer
2015-08-25 13:16   ` Jan Lübbe
2015-08-25 13:20 ` Jan Lübbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150825055040.GM18700@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=d.schultz@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox