From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXkN4-0002h5-N3 for barebox@lists.infradead.org; Fri, 04 Sep 2015 06:21:11 +0000 Date: Fri, 4 Sep 2015 08:20:48 +0200 From: Sascha Hauer Message-ID: <20150904062048.GT18700@pengutronix.de> References: <1440714250-28080-1-git-send-email-antonynpavlov@gmail.com> <1440714250-28080-4-git-send-email-antonynpavlov@gmail.com> <20150828063432.GA18700@pengutronix.de> <20150828184614.d0ec3d17f1800be9093f7fa3@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20150828184614.d0ec3d17f1800be9093f7fa3@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [RFC 3/9] MIPS: add virt_to_phys() and phys_to_virt() To: Antony Pavlov Cc: barebox@lists.infradead.org, Peter Mamonov On Fri, Aug 28, 2015 at 06:46:14PM +0300, Antony Pavlov wrote: > On Fri, 28 Aug 2015 08:34:32 +0200 > Sascha Hauer wrote: > > > On Fri, Aug 28, 2015 at 01:24:04AM +0300, Antony Pavlov wrote: > > > N.B. phys_to_virt() translates phys address > > > to KSEG1 (uncached) address as barebox mips > > > has no cache support. > > > > What would it take to implement cache support for mips? > lack of the cache support is critical problem for current barebox mips support. > I'm planning to add cache support in several weeks. > This task needs much test efforts for different boards. > > Anyway I can't carry out cache adding work at one. > But adding virt_to_phys and DMA support will help to add cache support one day anyway. Looking at this again the virt_to_phys/phys_to_virt macros are not necessary. dma_alloc_coherent() already returns both the virtual address and the DMA address. It should be possible to replace DMA_ADDRESS_BROKEN in the ehci driver with a real pointer and use it appropriatly in the driver. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox