From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-la0-x22f.google.com ([2a00:1450:4010:c03::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZeUZH-0000gy-NI for barebox@lists.infradead.org; Tue, 22 Sep 2015 20:53:40 +0000 Received: by lagj9 with SMTP id j9so28179301lag.2 for ; Tue, 22 Sep 2015 13:53:14 -0700 (PDT) Date: Wed, 23 Sep 2015 00:15:28 +0300 From: Antony Pavlov Message-Id: <20150923001528.23b1ed1272b82433164e6850@gmail.com> In-Reply-To: <1442937514-19675-2-git-send-email-pmamonov@gmail.com> References: <1442937514-19675-1-git-send-email-pmamonov@gmail.com> <1442937514-19675-2-git-send-email-pmamonov@gmail.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/5] common: clock: introduce mdelay_non_interruptible() To: Peter Mamonov Cc: barebox@lists.infradead.org On Tue, 22 Sep 2015 18:58:30 +0300 Peter Mamonov wrote: > Signed-off-by: Peter Mamonov > --- > common/clock.c | 8 ++++++++ > include/clock.h | 1 + > include/common.h | 1 + > 3 files changed, 10 insertions(+) > = > diff --git a/common/clock.c b/common/clock.c > index 35c9e6c..51cf9e4 100644 > --- a/common/clock.c > +++ b/common/clock.c > @@ -202,6 +202,14 @@ void mdelay(unsigned long msecs) > } > EXPORT_SYMBOL(mdelay); > = > +void mdelay_non_interruptible(unsigned long msecs) > +{ > + uint64_t start =3D get_time_ns(); > + > + while(!is_timeout_non_interruptible(start, msecs * MSECOND)); ERROR: space required before the open parenthesis '(' #107: FILE: common/clock.c:209: + while(!is_timeout_non_interruptible(start, msecs * MSECOND)); ERROR: trailing statements should be on next line #107: FILE: common/clock.c:209: + while(!is_timeout_non_interruptible(start, msecs * MSECOND)); > +} > +EXPORT_SYMBOL(mdelay_non_interruptible); > + > int init_clock(struct clocksource *cs) > { > current_clock =3D cs; > diff --git a/include/clock.h b/include/clock.h > index 691befc..68d71d7 100644 > --- a/include/clock.h > +++ b/include/clock.h > @@ -38,6 +38,7 @@ int is_timeout_non_interruptible(uint64_t start_ns, uin= t64_t time_offset_ns); > = > void ndelay(unsigned long nsecs); > void mdelay(unsigned long msecs); > +void mdelay_non_interruptible (unsigned long msecs); > = > #define SECOND ((uint64_t)(1000 * 1000 * 1000)) > #define MSECOND ((uint64_t)(1000 * 1000)) > diff --git a/include/common.h b/include/common.h > index 553a7f4..c576908 100644 > --- a/include/common.h > +++ b/include/common.h > @@ -72,6 +72,7 @@ void __noreturn poweroff(void); > /* lib_$(ARCH)/time.c */ > void udelay (unsigned long); > void mdelay (unsigned long); > +void mdelay_non_interruptible (unsigned long); > = > /* lib_generic/crc32.c */ > uint32_t crc32(uint32_t, const void*, unsigned int); > -- = > 2.1.4 > = > = > _______________________________________________ > barebox mailing list > barebox@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/barebox -- = --=A0 Best regards, =A0 Antony Pavlov _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox