From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: barebox@lists.infradead.org,
Edoardo Scaglia <scaglia@amelchem.com>,
Federico Braghiroli <braghiroli@amelchem.com>
Subject: Re: [PATCH] at91sam9x5: for ROM base address (bugfix for nand ECC)
Date: Fri, 2 Oct 2015 00:16:35 +0200 [thread overview]
Message-ID: <20151001221635.GB10444@piout.net> (raw)
In-Reply-To: <20151001214801.GA731@mail.gnudd.com>
On 01/10/2015 at 23:48:01 +0200, Alessandro Rubini wrote :
> From: Edoardo Scaglia <scaglia@amelchem.com>
>
> The ROM base address in the 9x5 processors lives at 1M, not 4M,
> where SMD is, as defined later in the same file.
>
> The ROM includes some tables that are used to build error-correction data
> for NAND memory. By using the wrong address, we get wrong data and
> the result is undetected bit flips (data at 0x408000 is all zeroes).
>
> Thus, even though our kernel was fixing bit errors in NAND, barebox
> was not fixing them. With UBI (our situation) we got I/O errors because
> the checksum verification for data nodes failed.
>
> Using the proper address corrects the problem: barebox reports a
> "bitflip" message, consistent with the kernel message for the same
> file, and the files are properly loaded and booted.
>
> Note: the kernel has the same wrong define, but then the magic number
> 0x00108000 as spelled in arch/arm/boot/dts/at91sam9x5.dtsi is used
> instead of the symbolic name.
>
> Signed-off-by: Edoardo Scaglia <scaglia@amelchem.com>
> Signed-off-by: Federico Braghiroli <braghiroli@amelchem.com>
> Signed-off-by: Alessndro Rubini <rubini@gnudd.com>
^
Typo in your name here
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2015-10-01 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 21:48 Alessandro Rubini
2015-10-01 21:59 ` Alessandro Rubini
2015-10-02 7:08 ` Sascha Hauer
2015-10-01 22:16 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151001221635.GB10444@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=barebox@lists.infradead.org \
--cc=braghiroli@amelchem.com \
--cc=rubini@gnudd.com \
--cc=scaglia@amelchem.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox