From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZqbfF-0002PA-PL for barebox@lists.infradead.org; Mon, 26 Oct 2015 06:53:54 +0000 Date: Mon, 26 Oct 2015 07:53:31 +0100 From: Sascha Hauer Message-ID: <20151026065331.GS14476@pengutronix.de> References: <1445629784-2024-1-git-send-email-eric@nelint.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1445629784-2024-1-git-send-email-eric@nelint.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] imx6-mmdc: fix automatic power down enable in write level calibration To: Eric Nelson Cc: barebox@lists.infradead.org Hi Eric, On Fri, Oct 23, 2015 at 12:49:44PM -0700, Eric Nelson wrote: > Bit 0 of the MAPSR register controls auto power down. > > Explicitly clear this bit instead of reserved bit when > exiting from mmdc_do_write_level_calibration(). > > Signed-off-by: Eric Nelson Looks good, applied. Did this bug have any practical impacts? Sascha > --- > arch/arm/mach-imx/imx6-mmdc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-imx/imx6-mmdc.c b/arch/arm/mach-imx/imx6-mmdc.c > index 64fb624..40fe0cf 100644 > --- a/arch/arm/mach-imx/imx6-mmdc.c > +++ b/arch/arm/mach-imx/imx6-mmdc.c > @@ -103,9 +103,9 @@ int mmdc_do_write_level_calibration(void) > val |= 0x00005500; > writel(val, (P0_IPS + MDPDC)); > > - /* enable Adopt power down timer: */ > + /* enable auto power down timer: */ > val = readl(P0_IPS + MAPSR); > - val &= 0xfffffff7; > + val &= ~1; > writel(val, (P0_IPS + MAPSR)); > > /* clear CON_REQ */ > -- > 2.6.2 > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox