mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Peter Mamonov <pmamonov@gmail.com>
To: Barebox List <barebox@lists.infradead.org>
Subject: [BUG] ata: disk_ata_drive: SSD drive doesn't pass check for ata id validity
Date: Thu, 29 Oct 2015 16:04:09 +0300	[thread overview]
Message-ID: <20151029160409.2ad22e14@berta> (raw)

Hi!

Barebox refuses to deal with OCZ-VERTEX4 ssd sata drive, because:
	ata1: ata id invalid

This error is triggered by the following piece of code :

static int ata_id_is_valid(const uint16_t *id)
{
	if ((id[ATA_ID_FIELD_VALID] & 1) == 0) {
		pr_debug("Drive's ID seems invalid\n");
		return -EINVAL;
	}

	return 0;
}

The "id" is a sector-sized block of bytes, received after
issuing ATA_CMD_ID_ATA command.

If I remove this check, the drive works fine.

Can someone with better knowledge of ATA standard comment on this
issue?

Regards,
Peter

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2015-10-29 13:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 13:04 Peter Mamonov [this message]
2015-10-30  7:31 ` Sascha Hauer
2015-10-30  8:53   ` Juergen Borleis
2015-10-30 10:06     ` Peter Mamonov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151029160409.2ad22e14@berta \
    --to=pmamonov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox