mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Zahari Doychev <zahari.doychev@linux.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] environment: allow saving of symbolic link changes
Date: Thu, 17 Dec 2015 10:52:04 +0100	[thread overview]
Message-ID: <20151217095204.GB11966@pengutronix.de> (raw)
In-Reply-To: <046392bf3e5eae8f1de0f482a23ed1691fb0d549.1450267988.git.zahari.doychev@linux.com>

Hi Zahari,

On Wed, Dec 16, 2015 at 01:24:43PM +0100, Zahari Doychev wrote:
> Currently it is not possible to change symbolic links in the default
> environment. For example if the default environment contains the
> link "current_boot -> mmc" then the following does not work:
> 
> $ rm current_boot
> $ ln net current_boot
> $ saveenv
> 
> After reset the link is still pointing to "mmc" and this error appears:
> 
> "symlink: /env/boot/current_boot -> net : error -17"
> 
> The patch fixes the above problem and moves the "ENV_FLAG_NO_OVERWRITE"
> to enable handling of symbolic links in this case too.
> 
> Signed-off-by: Zahari Doychev <zahari.doychev@linux.com>

Applied, thanks.

BTW for this particular case I would rather recommend using nv
variables, i.e. nv boot.default=net or nv boot.default=mmc; saveenv.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2015-12-17  9:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1450267988.git.zahari.doychev@linux.com>
2015-12-16 12:24 ` Zahari Doychev
2015-12-17  9:52   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151217095204.GB11966@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=zahari.doychev@linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox