mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: barebox@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/3] crypto: add enum
Date: Wed, 6 Jan 2016 17:55:50 +0100	[thread overview]
Message-ID: <20160106165550.GA8743@ravnborg.org> (raw)
In-Reply-To: <568D2733.4040304@pengutronix.de>

> >>  
> >> +struct digest *digest_alloc_by_algo(enum hash_algo hash_algo)
> >> +{
> >> +	struct digest *d;
> >> +	struct digest_algo *algo;
> >> +
> >> +	algo = digest_algo_get_by_algo(hash_algo);
> >> +	if (!algo)
> >> +		return NULL;
> >> +
> >> +	d = xzalloc(sizeof(*d));
> >> +	d->algo = algo;
> >> +	d->ctx = xzalloc(algo->ctx_length);
> > 
> > Neither allocations are checked for failure.
> 
> If xzalloc fails barebox will go into OOM and throw a backtrace.
Makes sense. I thought about this, but failed to go back
and check this myself.

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-01-06 16:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  8:11 [PATCH 0/3] FIT Support Marc Kleine-Budde
2016-01-05  8:11 ` [PATCH 1/3] crypto: add enum Marc Kleine-Budde
2016-01-05 16:54   ` Sam Ravnborg
2016-01-06 14:39     ` Marc Kleine-Budde
2016-01-06 16:55       ` Sam Ravnborg [this message]
2016-01-05  8:11 ` [PATCH 2/3] crypto: add RSA support Marc Kleine-Budde
2016-01-05  8:11 ` [PATCH 3/3] bootm: add initial FIT support Marc Kleine-Budde
2016-01-05 10:28   ` Yegor Yefremov
2016-01-05 10:32     ` Marc Kleine-Budde
2016-01-05 10:40       ` Yegor Yefremov
2016-01-05 11:54         ` Marc Kleine-Budde
2016-01-05 13:05           ` Yegor Yefremov
2016-01-05 13:50             ` Marc Kleine-Budde
2016-01-05 13:58               ` Yegor Yefremov
2016-01-07 17:09               ` Jan Lübbe
2016-01-08 10:36                 ` Yegor Yefremov
2016-01-05 20:28   ` Trent Piepho
2016-01-06 16:09     ` Marc Kleine-Budde
2016-01-07 17:00       ` Jan Lübbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160106165550.GA8743@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=kernel@pengutronix.de \
    --cc=mkl@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox