Re: [PATCH v4] Terasic DE0-Nano-SoC: add support

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Tim,

On Thu, Feb 11, 2016 at 03:40:41PM +0100, Tim Sander wrote:
> Hi
> 
> Am Montag, 1. Februar 2016, 11:08:10 schrieb Andrey Smirnov:
> ...
> > > diff --git a/arch/arm/boards/terasic-de0-nano-soc/board.c
> > > b/arch/arm/boards/terasic-de0-nano-soc/board.c new file mode 100644
> > > index 0000000..22f8291
> > > --- /dev/null
> > > +++ b/arch/arm/boards/terasic-de0-nano-soc/board.c
> > > @@ -0,0 +1,37 @@
> > > +#include <common.h>
> > > +#include <types.h>
> > > +#include <driver.h>
> > > +#include <init.h>
> > > +#include <asm/armlinux.h>
> > > +#include <linux/micrel_phy.h>
> > > +#include <linux/phy.h>
> > > +#include <linux/sizes.h>
> > > +#include <fcntl.h>
> > > +#include <fs.h>
> > > +#include <mach/socfpga-regs.h>
> > > +
> > > +static int phy_fixup(struct phy_device *dev)
> > > +{
> > > +       /* min rx data delay */
> > > +       phy_write(dev, 0x0b, 0x8105);
> > > +       phy_write(dev, 0x0c, 0x0000);
> > > +
> > > +       /* max rx/tx clock delay, min rx/tx control delay */
> > > +       phy_write(dev, 0x0b, 0x8104);
> > > +       phy_write(dev, 0x0c, 0xa0d0);
> > > +       phy_write(dev, 0x0b, 0x104);
> > > +
> > > +       return 0;
> > > +}
> > > +
> > > +static int socfpga_console_init(void)
> > 
> > I know that this names comes from the source code for SoCKit, but I'd
> > argue that the name of this function should be changed to something
> > more descriptive. This function doesn't really initialize console in
> > any way and just happen to be executed on "console_initcall" level of
> > execution.
> > 
> > > +{
> > > +       if (!of_machine_is_compatible("altr,socfpga-cyclone5"))
> The string above will be replaced with "terasic,de0-nano-soc" but see below...
> > > +               return 0;
> > 
> > Since Altera is not really a vendor of this board and, I'd suggest the
> > compatibility string be renamed to "terrasic,de0-nano-soc"
> Besides that the company is named Terasic i concur with you but there 
> is one problem: I have now just patched the kernel with the folowing patch to 
> add the device tree compatiblility information needed:
> 
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
> index 555e9caf21e1..3a427423168e 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_sockit.dts
> @@ -18,7 +18,7 @@
>  
>  / {
>         model = "Terasic DE-0(Atlas)";
> -       compatible = "altr,socfpga-cyclone5", "altr,socfpga";
> +       compatible = "terasic,de0-nano-soc"," altr,socfpga-cyclone5", "altr,socfpga";
>  
>         chosen {
>                 bootargs = "earlyprintk";
> -- 
> 1.9.1
> 
> But now i have  the barebox bootmessage which states the following on boot:
> --
> blspec: blspec_scan_directory: mmc loader/entries
> blspec: blspec_scan_directory: /mnt/mmc0.2 loader/entries
> blspec: ignoring entry with incompatible devicetree "terasic,de0-nano-soc"
> --

Ok, barebox finds a device tree compatible to "terasic,de0-nano-soc" on
the SD card, but thinks it itself is not compatible to that. It seems
the patch above has no effect. Could you check with of_dump that
/compatible is indeed what you expect it to be?

Note that you have a typo in your compatible string. " altr,socfpga-cyclone5"
should be "altr,socfpga-cyclone5". That should cause your problem
though.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox