From: Sascha Hauer <s.hauer@pengutronix.de>
To: Yegor Yefremov <yegorslists@googlemail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 3/3] fs: add support for SquashFS 4.0
Date: Wed, 17 Feb 2016 08:18:47 +0100 [thread overview]
Message-ID: <20160217071847.GK19372@pengutronix.de> (raw)
In-Reply-To: <CAGm1_ksKCs70eR+rmw-iWfzZO7SdGA1T6JEmkuwwhXzA=eqNWw@mail.gmail.com>
On Tue, Feb 16, 2016 at 09:38:03AM +0100, Yegor Yefremov wrote:
> On Tue, Feb 16, 2016 at 9:23 AM, <yegorslists@googlemail.com> wrote:
> > From: Yegor Yefremov <yegorslists@googlemail.com>
> >
> > The driver was imported from Linux 4.4.
> >
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > ---
> > Changes:
> > v2: - fix checkpatch errors
> > - remove spinlock/wait code from cache implementation
> > - fix directory listing
> > - add documentation entry about SquashFS
> > - fix compiling without XZ enabled
> > - fix some memory leaks
>
> Memory leaks:
>
> 1. mount still produces 20 bytes, that I still haven't identified
Does this accumulate if you repeat mount/unmount? Usually when
allocating/freeing bunches of memory you don't have the exact amount of
memory free afterwards.
> 2. ls -l has about 300 bytes, how do I best handle qstr duplicating?
> Its name is *const char **. If I'm doing alloc() I'm breaking this
> qualifier.
Why do you alloc? In squashfs_readdir() you can do a
nm.name = dentry->d_name.name instead of doing an extra allocation for
the string.
> 3. reading a file, i.e. cat has no memory leak so far according to meminfo
\o/
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-02-17 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 8:23 [PATCH v2 1/3] linux/types.h: add sector_t and blkcnt_t types yegorslists
2016-02-16 8:23 ` [PATCH v2 2/3] linux/fs.h: add types and routines needed for SquashFS yegorslists
2016-02-16 8:23 ` [PATCH v2 3/3] fs: add support for SquashFS 4.0 yegorslists
2016-02-16 8:38 ` Yegor Yefremov
2016-02-17 7:18 ` Sascha Hauer [this message]
2016-02-19 14:54 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217071847.GK19372@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox