From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aYp3s-0001rI-Hy for barebox@lists.infradead.Org; Thu, 25 Feb 2016 06:06:05 +0000 Date: Thu, 25 Feb 2016 07:05:39 +0100 From: Sascha Hauer Message-ID: <20160225060539.GT3939@pengutronix.de> References: <1455978465-28919-2-git-send-email-pmamonov@gmail.com> <1456310925-1057-1-git-send-email-pmamonov@gmail.com> <20160224172148.fd09cf0757b3b52348103638@gmail.com> <20160224180701.08b3d179@berta> <20160224181227.GR3939@pengutronix.de> <1456340037.25961.13.camel@rtred1test09.kymeta.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1456340037.25961.13.camel@rtred1test09.kymeta.local> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2] input: usb keyboard: fix CTRL+C To: Trent Piepho Cc: "barebox@lists.infradead.org" , Sam Ravnborg , Peter Mamonov On Wed, Feb 24, 2016 at 06:53:23PM +0000, Trent Piepho wrote: > On Wed, 2016-02-24 at 19:12 +0100, Sascha Hauer wrote: > > > > > > > > > > - if (modstate & (1 << 0)) > > > > > + if (modstate & (1 << 1)) > > > > > + ascii = keycode_bb_ctrl_keys[ev->code]; > > ascii = keycode_bb_keys[ev->code]; > ascii = ascii >= 'a' ? CTL_CH(ascii): 0; > > > > Sasha, did you mean to eliminate the CTRL-keymap completely? > > > > No, I didn't, although that would be an option aswell. It would safe us > > a few more bytes in the binary. The question is, how many more keys are > > in the CTRL map that are interesting for us? Are there more than CTRL-C? > > If yes, then it's probably better to keep the map. If not, a special > > CTRL-C case in code might be the better option. > > Would the above, or a slight modification, be ok? It gets almost all > the controls keys one could care about. Yes, this looks good. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox