mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup
@ 2016-02-26  8:56 Teresa Remmet
  2016-02-29  6:43 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Teresa Remmet @ 2016-02-26  8:56 UTC (permalink / raw)
  To: barebox

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
 common/oftree.c | 10 +++++-----
 include/of.h    |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/common/oftree.c b/common/oftree.c
index 3103bb1..e98b908 100644
--- a/common/oftree.c
+++ b/common/oftree.c
@@ -140,16 +140,16 @@ static int of_register_bootargs_fixup(void)
 late_initcall(of_register_bootargs_fixup);
 
 struct of_fixup_status_data {
-	char *node;
+	const char *path;
 	bool status;
 };
 
 static int of_fixup_status(struct device_node *root, void *context)
 {
-	struct of_fixup_status_data *data = context;
+	const struct of_fixup_status_data *data = context;
 	struct device_node *node;
 
-	node = of_find_node_by_path_or_alias(root, data->node);
+	node = of_find_node_by_path_or_alias(root, data->path);
 	if (!node)
 		return -ENODEV;
 
@@ -164,12 +164,12 @@ static int of_fixup_status(struct device_node *root, void *context)
  * Register a fixup to enable or disable a node in the devicet tree by
  * passing the path or alias.
  */
-int of_register_set_status_fixup(char *node, bool status)
+int of_register_set_status_fixup(const char *path, bool status)
 {
 	struct of_fixup_status_data *data;
 
 	data = xzalloc(sizeof(*data));
-	data->node = node;
+	data->path = path;
 	data->status = status;
 
 	return of_register_fixup(of_fixup_status, (void *)data);
diff --git a/include/of.h b/include/of.h
index ae65409..8c8f57a 100644
--- a/include/of.h
+++ b/include/of.h
@@ -249,7 +249,7 @@ int of_find_path(struct device_node *node, const char *propname, char **outpath,
 int of_find_path_by_node(struct device_node *node, char **outpath, unsigned flags);
 int of_register_fixup(int (*fixup)(struct device_node *, void *), void *context);
 int of_unregister_fixup(int (*fixup)(struct device_node *, void *), void *context);
-int of_register_set_status_fixup(char *node, bool status);
+int of_register_set_status_fixup(const char *node, bool status);
 struct device_node *of_find_node_by_alias(struct device_node *root,
 		const char *alias);
 struct device_node *of_find_node_by_path_or_alias(struct device_node *root,
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup
  2016-02-26  8:56 [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup Teresa Remmet
@ 2016-02-29  6:43 ` Sascha Hauer
  2016-02-29  8:19   ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2016-02-29  6:43 UTC (permalink / raw)
  To: Teresa Remmet; +Cc: barebox

On Fri, Feb 26, 2016 at 09:56:50AM +0100, Teresa Remmet wrote:
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
>  common/oftree.c | 10 +++++-----
>  include/of.h    |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)

Fixed up original commit, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup
  2016-02-29  6:43 ` Sascha Hauer
@ 2016-02-29  8:19   ` Uwe Kleine-König
  2016-03-01  7:26     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2016-02-29  8:19 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Teresa Remmet, barebox

On Mon, Feb 29, 2016 at 07:43:27AM +0100, Sascha Hauer wrote:
> On Fri, Feb 26, 2016 at 09:56:50AM +0100, Teresa Remmet wrote:
> > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > ---
> >  common/oftree.c | 10 +++++-----
> >  include/of.h    |  2 +-
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> Fixed up original commit, thanks

If that was automatic, there is also a typo in the Subject. s/fuc/func/

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup
  2016-02-29  8:19   ` Uwe Kleine-König
@ 2016-03-01  7:26     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2016-03-01  7:26 UTC (permalink / raw)
  To: Uwe Kleine-König; +Cc: Teresa Remmet, barebox

On Mon, Feb 29, 2016 at 09:19:59AM +0100, Uwe Kleine-König wrote:
> On Mon, Feb 29, 2016 at 07:43:27AM +0100, Sascha Hauer wrote:
> > On Fri, Feb 26, 2016 at 09:56:50AM +0100, Teresa Remmet wrote:
> > > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > > ---
> > >  common/oftree.c | 10 +++++-----
> > >  include/of.h    |  2 +-
> > >  2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > Fixed up original commit, thanks
> 
> If that was automatic, there is also a typo in the Subject. s/fuc/func/

The typo is in the original commit aswell, so no problem ;)

Fixed it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-03-01  7:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26  8:56 [PATCH for next] fixup! common: oftree: Add fuction to register set status fixup Teresa Remmet
2016-02-29  6:43 ` Sascha Hauer
2016-02-29  8:19   ` Uwe Kleine-König
2016-03-01  7:26     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox