From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] !fixup driver: replace dev_request_mem_region with dev_request_mem_resource
Date: Mon, 7 Mar 2016 09:14:30 +0100 [thread overview]
Message-ID: <20160307081430.GJ21869@pengutronix.de> (raw)
In-Reply-To: <1457324509-24857-1-git-send-email-andrew.smirnov@gmail.com>
On Sun, Mar 06, 2016 at 08:21:49PM -0800, Andrey Smirnov wrote:
> It looks like Coccinelle script failed to add register file
> initialization code at least in two places
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/i2c/busses/i2c-imx.c | 1 +
> drivers/usb/imx/imx-usb-phy.c | 1 +
> 2 files changed, 2 insertions(+)
It was missing in far more places. Should be fixed in the newest
version.
Sascha
> diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
> index 1017971..e407896 100644
> --- a/drivers/i2c/busses/i2c-imx.c
> +++ b/drivers/i2c/busses/i2c-imx.c
> @@ -610,6 +610,7 @@ static int __init i2c_fsl_probe(struct device_d *pdev)
> ret = PTR_ERR(iores);
> goto fail;
> }
> + i2c_fsl->base = IOMEM(iores->start);
>
> i2c_fsl_init_recovery(i2c_fsl, pdev);
>
> diff --git a/drivers/usb/imx/imx-usb-phy.c b/drivers/usb/imx/imx-usb-phy.c
> index 3306bd4..33e27da 100644
> --- a/drivers/usb/imx/imx-usb-phy.c
> +++ b/drivers/usb/imx/imx-usb-phy.c
> @@ -76,6 +76,7 @@ static int imx_usbphy_probe(struct device_d *dev)
> ret = PTR_ERR(iores);
> goto err_free;
> }
> + imxphy->base = IOMEM(iores->start);
>
> imxphy->clk = clk_get(dev, NULL);
> if (IS_ERR(imxphy->clk)) {
> --
> 2.5.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-03-07 8:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-07 4:21 Andrey Smirnov
2016-03-07 8:14 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160307081430.GJ21869@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox