mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Aleksey Kuleshov <rndfax@yandex.ru>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: [PATCH 2/2] input: make the Input Core be the last in the poller queue
Date: Fri, 11 Mar 2016 15:51:57 +0100	[thread overview]
Message-ID: <20160311145157.GN30994@pengutronix.de> (raw)
In-Reply-To: <2011061457699101@web8o.yandex.ru>

On Fri, Mar 11, 2016 at 03:25:01PM +0300, Aleksey Kuleshov wrote:
> > Here it is. It now works, presumable because of your recent change to
> > the interrupt transactions (ehci-hcd: preserve DTC in QH for interrupt
> > transactions).
> 
> I don't know what you mean, but this patch almost worked. I slightly changed it
> and I get working patch: I tested 4 keyboards, only one of them (some Genius)
> behave strangely, but this is not related to my recent patch you mentioned.
> 
> For Genius keyboard I got these messages:
>     Bus 001 Device 003: ID 1c4f:0026 USB Keyboard
>     usb-keyboard usb1-0-2: USB keyboard found
>     usb-keyboard usb1-0-2: Timeout poll on interrupt endpoint
>     usb-keyboard usb1-0-2: got wrong buffer back (00000000 instead of 82130fd8)
> 
> And tons of such messages:
>     usb-keyboard usb1-0-2: usb_submit_int_msg() failed. Keyboard disconnect?
> when there was screen scrolling (which is very slow in my case).
> 
> Can you elaborate a little what does not work in your case?

You misunderstood me. My patch works for me without issues. The question
is why it does, because last time I tested it it didn't work. I assume
that your "ehci-hcd: preserve DTC in QH for interrupt transactions"
patch which is now in my tree *fixes* the behaviour for me.

> 
> PS. Right now, I'm trying to investigate strange behaviour of Genius keyboard.
> I think next week I'll send you patch on your patch.

Thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-03-11 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03 15:17 [PATCH 1/2] poller: allow safely remove pollers in any time Aleksey Kuleshov
2016-03-03 15:17 ` [PATCH 2/2] input: make the Input Core be the last in the poller queue Aleksey Kuleshov
2016-03-04  7:19   ` Sascha Hauer
2016-03-04 10:18     ` Aleksey Kuleshov
2016-03-07  7:30       ` Sascha Hauer
2016-03-07  9:16         ` Aleksey Kuleshov
2016-03-10  9:26           ` Sascha Hauer
2016-03-11 12:25             ` Aleksey Kuleshov
2016-03-11 14:51               ` Sascha Hauer [this message]
2016-03-11 15:12                 ` Aleksey Kuleshov
2016-03-14 16:26             ` Aleksey Kuleshov
2016-03-16  7:17               ` Sascha Hauer
2016-03-03 16:54 ` [PATCH 1/2] poller: allow safely remove pollers in any time Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160311145157.GN30994@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=rndfax@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox