mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: barebox@lists.infradead.org,
	Daniel Krueger <daniel.krueger@systec-electronic.com>
Subject: Re: [PATCH 11/13] barebox-wrapper: Implement kfree and vfree as static inline functions
Date: Wed, 30 Mar 2016 08:19:30 +0200	[thread overview]
Message-ID: <20160330061930.GD30994@pengutronix.de> (raw)
In-Reply-To: <1458208829-25570-12-git-send-email-alexander.stein@systec-electronic.com>

Hi Alexander,

Just to let you know, I haven't forgot this series, I am currently
looking at it. I am currently having problems getting this compiled.

On Thu, Mar 17, 2016 at 11:00:27AM +0100, Alexander Stein wrote:
> If kfree/vfree is called where free is a already variable name, code will
> not compile.
> Also both take a const* in Linux kernel code.
> 
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  include/linux/barebox-wrapper.h | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/barebox-wrapper.h b/include/linux/barebox-wrapper.h
> index fc1b5c2..67b332e 100644
> --- a/include/linux/barebox-wrapper.h
> +++ b/include/linux/barebox-wrapper.h
> @@ -1,14 +1,21 @@
>  #ifndef __INCLUDE_LINUX_BAREBOX_WRAPPER_H
>  #define __INCLUDE_LINUX_BAREBOX_WRAPPER_H
>  
> +#include <malloc.h>

This makes problems for the decompressor code using the malloc
implementation in include/linux/decompress/mm.h. With this additional
include the normal malloc implementation leaks into the decompressor
code. I think I have a patch fixing it but must wait for the compile
test.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-03-30  6:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 10:00 [PATCH 00/13] ubifs update Alexander Stein
2016-03-17 10:00 ` [PATCH 01/13] mtd: cfi-flash: Set MTD's writebufsize Alexander Stein
2016-03-17 10:00 ` [PATCH 02/13] mtd: ubi: Set max_write_size to actual value read from flash Alexander Stein
2016-03-17 10:00 ` [PATCH 03/13] rbtree: Update to u-boot v2016.03 Alexander Stein
2016-03-17 10:00 ` [PATCH 04/13] printk: Add printk_once Alexander Stein
2016-03-17 10:00 ` [PATCH 05/13] Add list_sort from u-boot v2016.03 Alexander Stein
2016-03-17 10:00 ` [PATCH 06/13] printk: Add pr_cont Alexander Stein
2016-03-17 10:00 ` [PATCH 07/13] compiler*.h: include/linux/compiler*.h with Linux 4.5 Alexander Stein
2016-03-17 10:00 ` [PATCH 08/13] module.h: Add THIS_MODULE Alexander Stein
2016-03-17 10:00 ` [PATCH 09/13] ARM: Add atomic.h from u-boot v2016.03 Alexander Stein
2016-03-17 10:00 ` [PATCH 10/13] Move GFP_NOFS to barebox-wrapper Alexander Stein
2016-03-17 10:00 ` [PATCH 11/13] barebox-wrapper: Implement kfree and vfree as static inline functions Alexander Stein
2016-03-30  6:19   ` Sascha Hauer [this message]
2016-03-17 10:00 ` [PATCH 12/13] barebox-wrapper: Add kcalloc and __vmalloc Alexander Stein
2016-03-17 10:00 ` [PATCH 13/13] ubifs: update implementation from u-boot v2016.03 Alexander Stein
2016-07-19 11:41   ` Renaud Barbier
2016-07-21  6:30     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330061930.GD30994@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=alexander.stein@systec-electronic.com \
    --cc=barebox@lists.infradead.org \
    --cc=daniel.krueger@systec-electronic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox