From: Sascha Hauer <s.hauer@pengutronix.de>
To: Raphael Poggi <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] bitops: fls64: add missing include
Date: Thu, 14 Apr 2016 09:58:26 +0200 [thread overview]
Message-ID: <20160414075826.GB9102@pengutronix.de> (raw)
In-Reply-To: <1460557139-64673-1-git-send-email-poggi.raph@gmail.com>
On Wed, Apr 13, 2016 at 04:18:58PM +0200, Raphael Poggi wrote:
> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
> ---
> include/asm-generic/bitops/fls64.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/asm-generic/bitops/fls64.h b/include/asm-generic/bitops/fls64.h
> index 86d403f..e8eff76 100644
> --- a/include/asm-generic/bitops/fls64.h
> +++ b/include/asm-generic/bitops/fls64.h
> @@ -2,6 +2,7 @@
> #define _ASM_GENERIC_BITOPS_FLS64_H_
>
> #include <asm/types.h>
> +#include <asm-generic/bitops/__fls.h>
This is wrong. This include must not be here to give the architecture
the chance to provide an optimized version of __fls(), but the generic
version of fls64(). This may not be clear in barebox context since all
users use the generic version, but in the kernel there are some
architectures implementing their own version of __fls() while others use
the generic variant:
arch/mips/include/asm/bitops.h:480:static inline unsigned long __fls(unsigned long word)
...
#include <asm-generic/bitops/fls64.h>
arch/metag/include/asm/bitops.h:118:#include <asm-generic/bitops/__fls.h>
...
#include <asm-generic/bitops/fls64.h>
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-04-14 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 14:18 Raphael Poggi
2016-04-14 7:58 ` Sascha Hauer [this message]
2016-04-15 7:14 ` Raphaël Poggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414075826.GB9102@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=poggi.raph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox