mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: i.MX: increase barebox partition sizes
Date: Wed, 27 Apr 2016 11:25:01 +0200	[thread overview]
Message-ID: <20160427092501.GT7860@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5BvYEBGnZbT1aznEbgoZH_hZS=a+-phUz+wJPX02BmqFg@mail.gmail.com>

On Tue, Apr 26, 2016 at 08:47:28AM -0300, Fabio Estevam wrote:
> Hi Sascha,
> 
> On Tue, Apr 26, 2016 at 3:44 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > diff --git a/arch/arm/dts/imx25-karo-tx25.dts b/arch/arm/dts/imx25-karo-tx25.dts
> > index 8d79471..76847ff 100644
> > --- a/arch/arm/dts/imx25-karo-tx25.dts
> > +++ b/arch/arm/dts/imx25-karo-tx25.dts
> > @@ -123,12 +123,12 @@
> >
> >         partition@0 {
> >                 label = "boot";
> > -               reg = <0x0 0x80000>;
> > +               reg = <0x0 0xe0000>;
> >         };
> >
> > -       partition@80000 {
> > +       partition@e0000 {
> >                 label = "environment";
> > -               reg = <0x80000 0x80000>;
> > +               reg = <0xe0000 0x20000>;
> 
> Here the environment partition size is changed from 512kB to 128kB.
> Couldn't this cause issues?

Normally the environment is much smaller, so I wouldn't expect issues
here. The alternative to making the environment smaller would be to move
other partitions to the back. This would probably hurt more, especially
since a regular fdisk starts the first partition at offset 1MiB.

Another approach would be to use a MBR partition for the environment
instead of using the raw device.

> 
> Shouldn't this change be done by a separate patch?

We can't increase the barebox partition without shrinking the
environment right behind it. Or do you mean that we first shrink
the environment and in a second patch increase the barebox partition?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-04-27  9:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-26  6:44 Sascha Hauer
2016-04-26 11:47 ` Fabio Estevam
2016-04-27  9:25   ` Sascha Hauer [this message]
2016-04-27 12:43     ` Fabio Estevam
2016-04-27 12:51     ` Juergen Borleis
2016-04-27 13:36       ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160427092501.GT7860@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=festevam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox