mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Stefan Christ <s.christ@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 4/4] mtd: nand: nand_mxs: Add subpage read support
Date: Wed, 18 May 2016 08:52:16 +0200	[thread overview]
Message-ID: <20160518065216.GA2362@lws-christ> (raw)
In-Reply-To: <1462861483-19983-4-git-send-email-s.hauer@pengutronix.de>

Hi Sascha,

On Tue, May 10, 2016 at 08:24:43AM +0200, Sascha Hauer wrote:
> subpage read support can significantly speed up scanning UBI volumes, so
> add support for it. This is inspired by the corresponding Kernel commit.
> Unlike in the kernel we add subpage read support for i.MX28 aswell.
> Testing it on i.MX28 revealed no problems.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Here is my 

    Tested-by: Stefan Christ <s.christ@phytec.de>

I measured the ubiattach time for two different NAND chips after an ubiformat
on the devices. It's around 30% faster. Here are the results:

    nand: NAND device: Manufacturer ID: 0x01, Chip ID: 0xd3
    (AMD/Spansion S34ML08G2), 1024MiB, page size: 2048, OOB size: 128

    # without patches
    barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ time ubiattach  /dev/nand0.root
    UBI: scanning is finished
    UBI: registering /dev/nand0.root.ubi
    UBI: attached mtd0 (name "nand0.root", size 1010 MiB) to ubi0
    time: 9208ms

    # with patches
    barebox@Phytec phyFLEX-i.MX6 Quad Carrier-Board:/ time ubiattach  /dev/nand0.root
    time: 6524ms

    # Saved time 2684ms (-29%)
    

    nand: NAND device: Manufacturer ID: 0x2c, Chip ID: 0xdc
    (Micron MT29F4G08ABADAWP), 512MiB, page size: 2048, OOB size: 64

    # without patches 
    barebox@Phytec phyCORE-i.MX6 Duallite/SOLO with NAND:/ time ubiattach /dev/nand0.root
    time: 4158ms

    # with patches
    barebox@Phytec phyCORE-i.MX6 Duallite/SOLO with NAND:/ time ubiattach /dev/nand0.root
    time: 2842ms

    # Saved time 1316ms (-31%)

Mit freundlichen Grüßen / Kind regards,
	Stefan Christ

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-05-18  6:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  6:24 [PATCH 1/4] mtd: nand: nand_mxs: Factor out BCH setup function Sascha Hauer
2016-05-10  6:24 ` [PATCH 2/4] mtd: nand: Pass page argument to read_subpage hook Sascha Hauer
2016-05-10  6:24 ` [PATCH 3/4] mtd: nand: Enable subpage reads Sascha Hauer
2016-05-10  6:24 ` [PATCH 4/4] mtd: nand: nand_mxs: Add subpage read support Sascha Hauer
2016-05-18  6:52   ` Stefan Christ [this message]
2016-05-19  7:00     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160518065216.GA2362@lws-christ \
    --to=s.christ@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox