mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Raphael Poggi <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 03/12] arm: introduce lib64 for arm64 related stuff
Date: Fri, 3 Jun 2016 10:01:31 +0200	[thread overview]
Message-ID: <20160603080131.GU31666@pengutronix.de> (raw)
In-Reply-To: <1464854818-28653-4-git-send-email-poggi.raph@gmail.com>

On Thu, Jun 02, 2016 at 10:06:49AM +0200, Raphael Poggi wrote:
> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
> ---
>  arch/arm/lib64/Makefile         |  16 ++
>  arch/arm/lib64/armlinux.c       | 275 +++++++++++++++++++
>  arch/arm/lib64/asm-offsets.c    |  16 ++
>  arch/arm/lib64/barebox.lds      | 125 +++++++++
>  arch/arm/lib64/barebox.lds.S    | 125 +++++++++
>  arch/arm/lib64/bootm.c          | 572 ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/lib64/bootu.c          |  44 ++++
>  arch/arm/lib64/bootz.c          | 136 ++++++++++
>  arch/arm/lib64/copy_template.S  | 192 ++++++++++++++
>  arch/arm/lib64/div0.c           |  27 ++
>  arch/arm/lib64/memcpy.S         |  74 ++++++
>  arch/arm/lib64/memset.S         | 215 +++++++++++++++
>  arch/arm/lib64/module.c         |  98 +++++++
>  arch/arm/lib64/pbl.lds.S        |  96 +++++++
>  arch/arm/lib64/runtime-offset.S |  52 ++++
>  arch/arm/lib64/unwind.c         | 349 ++++++++++++++++++++++++
>  16 files changed, 2412 insertions(+)
>  create mode 100644 arch/arm/lib64/barebox.lds

This file shouldn't be necessary, it's generated from barebox.lds.S

>  create mode 100644 arch/arm/lib64/Makefile
>  create mode 100644 arch/arm/lib64/barebox.lds.S
>  create mode 100644 arch/arm/lib64/asm-offsets.c
>  create mode 100644 arch/arm/lib64/copy_template.S
>  create mode 100644 arch/arm/lib64/div0.c
>  create mode 100644 arch/arm/lib64/memcpy.S
>  create mode 100644 arch/arm/lib64/memset.S

These are most likely fine as they are. Can you make a separate patch
from them?

>  create mode 100644 arch/arm/lib64/bootm.c

Not sure how much should be merged into common code for arm/arm64. We
can keep it like this for now.

>  create mode 100644 arch/arm/lib64/bootu.c
>  create mode 100644 arch/arm/lib64/bootz.c

These shouldn't be needed for arm64, bootm.c is enough.

>  create mode 100644 arch/arm/lib64/module.c

We can drop module support for arm64. I guess this would need
substantial changes for arm64 anyway, so we can remove it here.

>  create mode 100644 arch/arm/lib64/pbl.lds.S
>  create mode 100644 arch/arm/lib64/runtime-offset.S
>  create mode 100644 arch/arm/lib64/unwind.c

How much of this code is already used? If it's unused you can remove it
for now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-06-03  8:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  8:06 [PATCH 0/12] Add basic support for arm64 Raphael Poggi
2016-06-02  8:06 ` [PATCH 01/12] arm: add armv8 Kconfig entries Raphael Poggi
2016-06-02  8:06 ` [PATCH 02/12] arm: Makefile: rework makefile to handle armv8 Raphael Poggi
2016-06-03  7:27   ` Sascha Hauer
2016-06-03  7:33     ` Raphaël Poggi
2016-06-02  8:06 ` [PATCH 03/12] arm: introduce lib64 for arm64 related stuff Raphael Poggi
2016-06-03  8:01   ` Sascha Hauer [this message]
2016-06-02  8:06 ` [PATCH 04/12] arm: cpu: add arm64 specific code Raphael Poggi
2016-06-03  8:07   ` Sascha Hauer
2016-06-02  8:06 ` [PATCH 05/12] arm: include: system: add arm64 helper functions Raphael Poggi
2016-06-02  8:06 ` [PATCH 06/12] arm: cpu: start: arm64 does not support relocation Raphael Poggi
2016-06-02  8:06 ` [PATCH 07/12] arm: include: bitops: arm64 use generic __fls Raphael Poggi
2016-06-02  8:06 ` [PATCH 08/12] arm: include: system_info: add armv8 identification Raphael Poggi
2016-06-02  8:06 ` [PATCH 09/12] arm: cpu: cpuinfo: add armv8 support Raphael Poggi
2016-06-02  8:06 ` [PATCH 10/12] arm: cpu: disable code portion in armv8 case Raphael Poggi
2016-06-02  8:06 ` [PATCH 11/12] arm: cpu: add basic arm64 mmu support Raphael Poggi
2016-06-03  8:30   ` Sascha Hauer
2016-06-02  8:06 ` [PATCH 12/12] arm: boards: add virt board Raphael Poggi
2016-06-03  8:50   ` Sascha Hauer
2016-06-07  7:13     ` Raphaël Poggi
2016-06-07 11:00   ` Antony Pavlov
2016-06-07 11:53     ` Raphaël Poggi
2016-06-07 12:59       ` Antony Pavlov
2016-06-07 13:16         ` Raphaël Poggi
2016-06-03  9:16 ` [PATCH 0/12] Add basic support for arm64 Sascha Hauer
2016-06-03  9:25   ` Raphaël Poggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160603080131.GU31666@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox