mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <aar@pengutronix.de>
To: barebox@lists.infradead.org
Cc: Alexander Aring <aar@pengutronix.de>
Subject: [PATCH 1/2] ifup: remove deletion of ip env
Date: Tue, 14 Jun 2016 08:55:05 +0200	[thread overview]
Message-ID: <20160614065506.25821-1-aar@pengutronix.de> (raw)

This patch removes the deletion of ip env and changes to the behaviour
that it use previous ip=$TYPE assignments if ip env is not part of network
env which will be sourced.

Example:
somewhere in shell: ip=dhcp
\- in case of ip=$TYPE in network env: overwrites the ip env
\- in case of NO ip=$TYPE in network env: use the ip="dhcp" from shell

Signed-off-by: Alexander Aring <aar@pengutronix.de>
---
Don't know if this patch breaks to much handling with previous env handling,
but I would except such handling.

Also don't know if the example is correct or I mixed something with
global/local envs.

Maybe apply patch 2/2 only.

 net/ifup.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/ifup.c b/net/ifup.c
index f22afc9..17e1b2f 100644
--- a/net/ifup.c
+++ b/net/ifup.c
@@ -62,8 +62,6 @@ int ifup(const char *name, unsigned flags)
 
 	env_push_context();
 
-	setenv("ip", "");
-
 	for (i = 0; i < ARRAY_SIZE(vars); i++)
 		setenv(vars[i], "");
 
-- 
2.8.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2016-06-14  6:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14  6:55 Alexander Aring [this message]
2016-06-14  6:55 ` [PATCH 2/2] ifup: fix handling when ip env is not given Alexander Aring
2016-06-15  5:43   ` Sascha Hauer
2016-06-15  5:40 ` [PATCH 1/2] ifup: remove deletion of ip env Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160614065506.25821-1-aar@pengutronix.de \
    --to=aar@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox