mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Antony Pavlov <antonynpavlov@gmail.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Subject: Re: [PATCH 3/3] GUI: Add fbtest command
Date: Wed, 22 Jun 2016 13:49:13 +0300	[thread overview]
Message-ID: <20160622134913.7719306547ef43001d163c71@gmail.com> (raw)
In-Reply-To: <1466570369-1950-3-git-send-email-andrew.smirnov@gmail.com>

On Tue, 21 Jun 2016 21:39:29 -0700
Andrey Smirnov <andrew.smirnov@gmail.com> wrote:

> Add 'fbtest' - a command to produce test patterns on a screen
                                                    ^^^^^^^^^^^ "on A screen" here


...

> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -1417,6 +1417,15 @@ config CMD_SPLASH
>  		  -b COLOR	background color in 0xttrrggbb
>  		  -o		render offscreen
>  
> +config CMD_FBTEST
> +	bool
> +	depends on VIDEO
> +	select 2D_PRIMITIVES
> +	prompt "FB test"
> +	help
> +	  Framebuffer test command that allows to produce a number of
> +	  test patterns on the screen.
                        ^^^^^^^^^^^^^ "on THE screen" here

Can you fix this inconsistency, please?

-- 
Best regards,
  Antony Pavlov

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-06-22 10:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-22  4:39 [PATCH 1/3] GUI: Add a function to draw solid rectangles Andrey Smirnov
2016-06-22  4:39 ` [PATCH 2/3] GUI: Add code to draw simple graphics Andrey Smirnov
2016-06-23  7:30   ` Holger Schurig
2016-06-24  4:57     ` Andrey Smirnov
2016-06-22  4:39 ` [PATCH 3/3] GUI: Add fbtest command Andrey Smirnov
2016-06-22 10:49   ` Antony Pavlov [this message]
2016-06-24  4:50     ` Andrey Smirnov
2016-06-22 10:57   ` Antony Pavlov
2016-06-24  3:18     ` Andrey Smirnov
2016-06-23  6:22   ` Sascha Hauer
2016-06-24  3:21     ` Andrey Smirnov
2016-06-23  7:31   ` Holger Schurig
2016-06-23  9:28     ` Sascha Hauer
2016-06-24  4:49     ` Andrey Smirnov
2016-06-23  7:28 ` [PATCH 1/3] GUI: Add a function to draw solid rectangles Holger Schurig
2016-06-24  5:00   ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160622134913.7719306547ef43001d163c71@gmail.com \
    --to=antonynpavlov@gmail.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox