mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Raphaël Poggi" <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v3 06/14] arm: cpu: start: arm64 does not support relocation
Date: Tue, 28 Jun 2016 09:02:45 +0200	[thread overview]
Message-ID: <20160628070245.GM20657@pengutronix.de> (raw)
In-Reply-To: <CACqcpZDH01ounyRH4UgJ4-f-BCpZ_YSRSwn2wwnnXHxc29-vsA@mail.gmail.com>

On Tue, Jun 28, 2016 at 09:01:14AM +0200, Raphaël Poggi wrote:
> 2016-06-28 8:50 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> > On Fri, Jun 24, 2016 at 02:23:53PM +0200, Raphael Poggi wrote:
> >> For now, the relocation is not supported in arm64, so
> >> enclosed call to "setup_c" with #if directive
> >>
> >> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
> >> ---
> >>  arch/arm/cpu/start.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/arch/arm/cpu/start.c b/arch/arm/cpu/start.c
> >> index e037d91..5051115 100644
> >> --- a/arch/arm/cpu/start.c
> >> +++ b/arch/arm/cpu/start.c
> >> @@ -151,7 +151,9 @@ __noreturn void barebox_non_pbl_start(unsigned long membase,
> >>               relocate_to_adr(barebox_base);
> >>       }
> >>
> >> +#if __LINUX_ARM_ARCH__ <= 7
> >>       setup_c();
> >> +#endif
> >
> > setup_c not only relocates the binary, it also clears the bss segment.
> > Where is this done on arm64?
> 
> It is not done...I forgot about that.
> 
> I will create a setupc_64.S, in the first time, this will only clear
> bss. Later, we could also add relocation support.

Ok, that should do it for now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2016-06-28  7:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 12:23 [PATCH v3 0/12] Add basic support for arm64 Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 01/14] arm: add armv8 Kconfig entries Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 02/14] arm: Makefile: rework makefile to handle armv8 Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 03/14] arm: introduce lib64 for arm64 related stuff Raphael Poggi
2016-06-28  6:47   ` Sascha Hauer
2016-06-28  7:15     ` Raphaël Poggi
2016-06-29  6:00       ` Sascha Hauer
2016-06-29  6:36         ` Raphaël Poggi
2016-06-24 12:23 ` [PATCH v3 04/14] arm: cpu: add arm64 specific code Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 05/14] arm: include: system: add arm64 helper functions Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 06/14] arm: cpu: start: arm64 does not support relocation Raphael Poggi
2016-06-28  6:50   ` Sascha Hauer
2016-06-28  7:01     ` Raphaël Poggi
2016-06-28  7:02       ` Sascha Hauer [this message]
2016-06-24 12:23 ` [PATCH v3 07/14] arm: include: bitops: arm64 use generic __fls Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 08/14] arm: include: system_info: add armv8 identification Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 09/14] arm: cpu: cpuinfo: add armv8 support Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 10/14] arm: cpu: disable code portion in armv8 case Raphael Poggi
2016-06-24 12:23 ` [PATCH v3 11/14] arm: cpu: add basic arm64 mmu support Raphael Poggi
2016-06-28  7:01   ` Sascha Hauer
2016-06-24 12:23 ` [PATCH v3 12/14] arm: boards: add mach-qemu and virt64 board Raphael Poggi
2016-06-24 12:24 ` [PATCH v3 13/14] arm: include: swab: use rigth assembly for armv8 Raphael Poggi
2016-06-24 12:24 ` [PATCH v3 14/14] uimage: add define for ARM64 architecture Raphael Poggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160628070245.GM20657@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox