From: Antony Pavlov <antonynpavlov@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] input: Compile keymap only if necessary
Date: Mon, 4 Jul 2016 16:48:10 +0300 [thread overview]
Message-ID: <20160704164810.ad22e9243d6bd0541a637888@gmail.com> (raw)
In-Reply-To: <1466358813-31528-1-git-send-email-shc_work@mail.ru>
On Sun, 19 Jun 2016 20:53:33 +0300
Alexander Shiyan <shc_work@mail.ru> wrote:
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> drivers/input/Makefile | 3 +--
> include/input/keyboard.h | 4 ++++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/Makefile b/drivers/input/Makefile
> index 7d2c194..e694a98 100644
> --- a/drivers/input/Makefile
> +++ b/drivers/input/Makefile
> @@ -1,8 +1,7 @@
> -obj-$(CONFIG_INPUT) += input.o
> +obj-$(CONFIG_INPUT) += input.o keymap.o
> obj-$(CONFIG_INPUT_MATRIXKMAP) += matrix-keymap.o
> obj-$(CONFIG_KEYBOARD_USB) += usb_kbd.o
> obj-$(CONFIG_KEYBOARD_GPIO) += gpio_keys.o
> obj-$(CONFIG_KEYBOARD_TWL6030) += twl6030_pwrbtn.o
> obj-$(CONFIG_KEYBOARD_IMX_KEYPAD) += imx_keypad.o
> obj-$(CONFIG_KEYBOARD_QT1070) += qt1070.o
> -obj-y += keymap.o
> diff --git a/include/input/keyboard.h b/include/input/keyboard.h
> index d1f5bf5..e205a51 100644
> --- a/include/input/keyboard.h
> +++ b/include/input/keyboard.h
> @@ -1,6 +1,8 @@
> #ifndef __INPUT_KEYBOARD_H
> #define __INPUT_KEYBOARD_H
>
> +#ifdef CONFIG_INPUT
> +
Do we really need this?
> #include <linux/types.h>
>
> #define NR_KEYS 256
> @@ -9,3 +11,5 @@ extern uint8_t keycode_bb_keys[NR_KEYS];
> extern uint8_t keycode_bb_shift_keys[NR_KEYS];
>
> #endif
> +
> +#endif
> --
> 2.4.9
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-04 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-19 17:53 Alexander Shiyan
2016-06-20 6:34 ` Sascha Hauer
2016-07-04 13:48 ` Antony Pavlov [this message]
2016-07-11 6:31 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160704164810.ad22e9243d6bd0541a637888@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox