From: Sascha Hauer <s.hauer@pengutronix.de>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH 10/12] ARM: i.MX53 Vincell: Add NAND xload support
Date: Tue, 5 Jul 2016 09:00:48 +0200 [thread overview]
Message-ID: <20160705070048.GO20657@pengutronix.de> (raw)
In-Reply-To: <20160704125834.GA15608@pengutronix.de>
On Mon, Jul 04, 2016 at 02:58:34PM +0200, Michael Grzeschik wrote:
> On Mon, Jul 04, 2016 at 11:27:37AM +0200, Sascha Hauer wrote:
> > The Vincell boards do the SDRAM setup from board init code, so the
> > image size is limited to the internal SRAM size. To overcome this
> > limitation use the NAND xload support.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > arch/arm/boards/guf-vincell/lowlevel.c | 25 ++++++++++++++++++++++---
> > arch/arm/mach-imx/Kconfig | 9 +++++++++
> > images/Makefile.imx | 14 ++++++++++----
> > 3 files changed, 41 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm/boards/guf-vincell/lowlevel.c b/arch/arm/boards/guf-vincell/lowlevel.c
> > index f4bd44e..34c28f7 100644
> > --- a/arch/arm/boards/guf-vincell/lowlevel.c
> > +++ b/arch/arm/boards/guf-vincell/lowlevel.c
> > @@ -11,6 +11,7 @@
> > #include <mach/generic.h>
> > #include <asm/barebox-arm.h>
> > #include <asm/barebox-arm-head.h>
> > +#include <mach/xload.h>
> >
> > #define IOMUX_PADCTL_DDRI_DDR (1 << 9)
> >
> > @@ -127,8 +128,9 @@ static noinline void imx53_guf_vincell_init(void *fdt)
> > {
> > void __iomem *ccm = (void *)MX53_CCM_BASE_ADDR;
> > u32 r;
> > + enum bootsource src;
> > + int instance;
> >
> > - imx5_cpu_lowlevel_init();
> > arm_setup_stack(0xf8020000 - 8);
> >
> > writel(0x0088494c, ccm + MX5_CCM_CBCDR);
> > @@ -149,11 +151,28 @@ static noinline void imx53_guf_vincell_init(void *fdt)
> > disable_watchdog();
> > configure_dram_iomux();
> > imx_esdctlv4_init();
> > +
> > + imx53_get_boot_source(&src, &instance);
> > +
> > + if (src == BOOTSOURCE_NAND &&
> > + is_enabled(CONFIG_MACH_GUF_VINCELL_XLOAD))
> > + imx53_nand_start_image();
>
> This should probably be s/is_enabled/IS_ENABLED/ .
Yes, indeed. I thought I at least compile tested this change /o\
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-05 7:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 9:27 i.MX53 " Sascha Hauer
2016-07-04 9:27 ` [PATCH 01/12] ARM: i.MX53: do not pass base address to imx*_boot_save_loc Sascha Hauer
2016-07-04 9:27 ` [PATCH 02/12] ARM: i.MX: Provide bootsource functions for early boot code Sascha Hauer
2016-07-04 9:27 ` [PATCH 03/12] ARM: i.MX53: Detect booting from USB Sascha Hauer
2016-07-04 9:27 ` [PATCH 04/12] mtd: imx-nand: Move v3 register definitions to include file Sascha Hauer
2016-07-04 9:27 ` [PATCH 05/12] ARM: i.MX53: Implement NAND xload Sascha Hauer
2016-07-04 9:27 ` [PATCH 06/12] ARM: i.MX53: Add uart5 clock support Sascha Hauer
2016-07-04 9:27 ` [PATCH 07/12] ARM: i.MX53 Vincell: Reset phy consistently from device tree Sascha Hauer
2016-07-04 9:27 ` [PATCH 08/12] ARM: i.MX53 Vincell: Adjust bbu handler partition size to real partition size Sascha Hauer
2016-07-04 9:27 ` [PATCH 09/12] ARM: i.MX53 Vincell: Add PBL console support Sascha Hauer
2016-07-04 9:27 ` [PATCH 10/12] ARM: i.MX53 Vincell: Add NAND xload support Sascha Hauer
2016-07-04 12:58 ` Michael Grzeschik
2016-07-05 7:00 ` Sascha Hauer [this message]
2016-07-04 9:27 ` [PATCH 11/12] ARM: imx_v7_defconfig: Enable Vincell support Sascha Hauer
2016-07-04 9:27 ` [PATCH 12/12] ARM: vincell_defconfig: make smaller Sascha Hauer
2016-09-14 9:12 [PATCH 01/12] ARM: i.MX53: Add uart5 clock support Sascha Hauer
2016-09-14 9:12 ` [PATCH 10/12] ARM: i.MX53 Vincell: Add NAND xload support Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705070048.GO20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mgr@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox