From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Kurz <akurz@blala.de>
Cc: barebox@lists.infradead.org, s.mueller-klieser@phytec.de
Subject: Re: [PATCH] ARM: bootm: recalculate decompression space
Date: Tue, 5 Jul 2016 11:58:49 +0200 [thread overview]
Message-ID: <20160705095849.GP20657@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.00.1607051138040.23712@blala.de>
On Tue, Jul 05, 2016 at 11:47:08AM +0200, Alexander Kurz wrote:
> Hi Stefan,
> FYI, I just got a compiler warning obviously related to your patch
> On Fri Jul 1 07:48:39 PDT 2016, Stefan Müller-Klieser wrote:
>
> > diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> > index 803aa94..be1259b 100644
> > --- a/arch/arm/lib/bootm.c
> > +++ b/arch/arm/lib/bootm.c
> > @@ -81,10 +81,15 @@ static int get_kernel_addresses(size_t image_size,
> > return ret;
> >
> > /*
> > - * We don't know the exact decompressed size so just use a
> > conservative
> > - * default of 4 times the size of the compressed image.
> > + * The kernel documentation "Documentation/arm/Booting" advises
> > + * to place the compressed image outside of the lowest 32 MiB to
> > + * avoid relocation. We should do this if we have at least 64 MiB
> > + * of ram. If we have less space, we assume a maximum
> > + * compression factor of 5.
> > */
> > - image_decomp_size = PAGE_ALIGN(image_size * 4);
> > + image_decomp_size = PAGE_ALIGN(image_size * 5);
> > + if (mem_size >= SZ_64M)
> > + image_decomp_size = max(image_decomp_size, SZ_32M);
> >
> > /*
> > * By default put oftree/initrd close behind compressed kernel
> > image to
>
> this one:
> > CC arch/arm/lib/bootm.o
> > In file included from include/common.h:30:0,
> > from arch/arm/lib/bootm.c:2:
> > arch/arm/lib/bootm.c: In function 'get_kernel_addresses':
> > include/linux/kernel.h:110:17: warning: comparison of distinct pointer
> > types lacks a cast
> > (void) (&_max1 == &_max2); \
I get that aswell. Will change to:
max_t(size_t, image_decomp_size, SZ_32M);
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-05 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.00.1607051136430.23712@blala.de>
2016-07-05 9:47 ` Alexander Kurz
2016-07-05 9:58 ` Sascha Hauer [this message]
2016-07-01 14:48 Stefan Müller-Klieser
2016-07-04 9:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705095849.GP20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=akurz@blala.de \
--cc=barebox@lists.infradead.org \
--cc=s.mueller-klieser@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox