From: Sascha Hauer <s.hauer@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/7] mfd: syscon: Decouple syscon interface from platform devices
Date: Fri, 15 Jul 2016 07:59:52 +0200 [thread overview]
Message-ID: <20160715055952.GG20657@pengutronix.de> (raw)
In-Reply-To: <1468476665-26409-3-git-send-email-andrew.smirnov@gmail.com>
On Wed, Jul 13, 2016 at 11:11:01PM -0700, Andrey Smirnov wrote:
> Follow Linux Kernel change introduced in
> bdb0066df96e74a4002125467ebe459feff1ebef and avoid device/driver model
> for DT-based platforms. See the original kernel commit for the rationale.
>
> Also make syscon_base_lookup_by_pdevname() behave the same way as its
> kernel counterpart in the case whern "property" argument is NULL.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> drivers/mfd/syscon.c | 79 ++++++++++++++++++++++++++++++++++++++++------------
> 1 file changed, 61 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index ac46122..5fd22dd 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -17,15 +17,68 @@
> #include <driver.h>
> #include <malloc.h>
> #include <xfuncs.h>
> -
> +#include <of_address.h>
> #include <linux/err.h>
>
> #include <mfd/syscon.h>
>
> +static LIST_HEAD(syscon_list);
> +
> struct syscon {
> + struct device_node *np;
> void __iomem *base;
> + struct list_head list;
> };
>
> +static struct syscon *of_syscon_register(struct device_node *np)
> +{
> + int ret;
> + struct syscon *syscon;
> + struct resource res;
> +
> + if (!of_device_is_compatible(np, "syscon"))
> + return ERR_PTR(-EINVAL);
> +
> + syscon = xzalloc(sizeof(*syscon));
> +
> + if (of_address_to_resource(np, 0, &res)) {
> + ret = -ENOMEM;
> + goto err_map;
> + }
> +
> + syscon->base = IOMEM(res.start);
> + syscon->np = np;
> +
> + list_add_tail(&syscon->list, &syscon_list);
> +
> + return syscon;
> +
> +err_map:
> + kfree(syscon);
> + return ERR_PTR(ret);
> +}
> +
> +void __iomem *syscon_node_to_base(struct device_node *np)
This should either be static or the prototype added to include/
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-15 6:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 6:10 [PATCH 1/7] Revert "syscon: Decrease driver registration priority" Andrey Smirnov
2016-07-14 6:11 ` [PATCH 2/7] mfd: syscon: Don't call request_iomem_region() Andrey Smirnov
2016-07-15 5:53 ` Sascha Hauer
2016-07-15 9:11 ` Re[2]: " Alexander Shiyan
2016-07-14 6:11 ` [PATCH 3/7] mfd: syscon: Decouple syscon interface from platform devices Andrey Smirnov
2016-07-15 5:59 ` Sascha Hauer [this message]
2016-07-15 21:50 ` Andrey Smirnov
2016-07-18 6:18 ` Sascha Hauer
2016-07-14 6:11 ` [PATCH 4/7] mfd: syscon: Don't check xzalloc return for NULL Andrey Smirnov
2016-07-14 6:11 ` [PATCH 5/7] mfd: syscon: Use IOMEM instead of explicit cast Andrey Smirnov
2016-07-14 6:11 ` [PATCH 6/7] imx_thermal: Remove leftover debug output Andrey Smirnov
2016-07-14 6:11 ` [PATCH 7/7] i.MX: ocotp: Register regmap against orignal device Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715055952.GG20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox