From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ge.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] bbu: parameters are inverted in error message
Date: Mon, 15 Aug 2016 10:16:00 +0200 [thread overview]
Message-ID: <20160815081600.GS20657@pengutronix.de> (raw)
In-Reply-To: <1470218005-20457-1-git-send-email-renaud.barbier@ge.com>
On Wed, Aug 03, 2016 at 10:53:25AM +0100, Renaud Barbier wrote:
> The error message warning the user that the image is too big for
> the device has its parameters in the wrong order. Swap the two
> parameters so that the output makes sense.
>
> Signed-off-by: Renaud Barbier <renaud.barbier@ge.com>
> ---
> common/bbu.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/common/bbu.c b/common/bbu.c
> index 1b22139..c5dda8c 100644
> --- a/common/bbu.c
> +++ b/common/bbu.c
> @@ -307,8 +307,8 @@ static int bbu_std_file_handler(struct bbu_handler *handler,
> oflags |= O_CREAT;
> } else {
> if (!S_ISREG(s.st_mode) && s.st_size < data->len) {
> - printf("Image (%lld) is too big for device (%zd)\n",
> - s.st_size, data->len);
> + printf("Image (%zd) is too big for device (%lld)\n",
> + data->len, s.st_size);
> }
> }
>
> --
> 1.7.1
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-08-15 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 9:53 Renaud Barbier
2016-08-15 8:16 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815081600.GS20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=renaud.barbier@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox