From: Sascha Hauer <s.hauer@pengutronix.de>
To: Aleksey Kuleshov <rndfax@yandex.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] fix double free
Date: Thu, 18 Aug 2016 09:13:12 +0200 [thread overview]
Message-ID: <20160818071312.GH20657@pengutronix.de> (raw)
In-Reply-To: <1471423924-8745-1-git-send-email-rndfax@yandex.ru>
On Wed, Aug 17, 2016 at 11:52:04AM +0300, Aleksey Kuleshov wrote:
> it already gets free in bootentries_free
> no need to do this in ->release method
>
> Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
> ---
> common/boot.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/common/boot.c b/common/boot.c
> index a2f5a81..52e181d 100644
> --- a/common/boot.c
> +++ b/common/boot.c
> @@ -169,7 +169,6 @@ static void bootscript_entry_release(struct bootentry *entry)
> struct bootentry_script *bs = container_of(entry, struct bootentry_script, entry);
>
> free(bs->scriptpath);
> - free(bs->entry.me.display);
> free(bs);
> }
>
> --
> 2.8.0.rc3
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2016-08-18 7:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 8:52 Aleksey Kuleshov
2016-08-18 7:13 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818071312.GH20657@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rndfax@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox