[PATCH] fix double free

[PATCH] fix double free

[Aleksey Kuleshov]

it already gets free in bootentries_free
no need to do this in ->release method

Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
---
 common/boot.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/common/boot.c b/common/boot.c
index a2f5a81..52e181d 100644
--- a/common/boot.c
+++ b/common/boot.c
@@ -169,7 +169,6 @@ static void bootscript_entry_release(struct bootentry *entry)
 	struct bootentry_script *bs = container_of(entry, struct bootentry_script, entry);
 
 	free(bs->scriptpath);
-	free(bs->entry.me.display);
 	free(bs);
 }
 
-- 
2.8.0.rc3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] fix double free

[Sascha Hauer]

On Wed, Aug 17, 2016 at 11:52:04AM +0300, Aleksey Kuleshov wrote:
> it already gets free in bootentries_free
> no need to do this in ->release method
> 
> Signed-off-by: Aleksey Kuleshov <rndfax@yandex.ru>
> ---
>  common/boot.c | 1 -
>  1 file changed, 1 deletion(-)

Applied, thanks

Sascha

> 
> diff --git a/common/boot.c b/common/boot.c
> index a2f5a81..52e181d 100644
> --- a/common/boot.c
> +++ b/common/boot.c
> @@ -169,7 +169,6 @@ static void bootscript_entry_release(struct bootentry *entry)
>  	struct bootentry_script *bs = container_of(entry, struct bootentry_script, entry);
>  
>  	free(bs->scriptpath);
> -	free(bs->entry.me.display);
>  	free(bs);
>  }
>  
> -- 
> 2.8.0.rc3
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox