From: Antony Pavlov <antonynpavlov@gmail.com>
To: Michael Olbrich <m.olbrich@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 1/3] state: copy backend of_path string
Date: Fri, 16 Sep 2016 11:12:43 +0300 [thread overview]
Message-ID: <20160916111243.1dc2a3f16421fb33831817a0@gmail.com> (raw)
In-Reply-To: <1474008220-7601-1-git-send-email-m.olbrich@pengutronix.de>
On Fri, 16 Sep 2016 08:43:38 +0200
Michael Olbrich <m.olbrich@pengutronix.de> wrote:
> Caching pointers to device tree nodes or names is not save. The barebox
^^^^ safe?
> internal device tree may be changed by loading a new device tree or through
> fixup handlers. As a result, the string may be deleted.
> Use local copies of the full path instead.
>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-09-16 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 6:43 Michael Olbrich
2016-09-16 6:43 ` [PATCH v2 2/3] state: don't keep pointers to device tree nodes Michael Olbrich
2016-09-16 6:43 ` [PATCH v2 3/3] state: fix finding the correct parent node Michael Olbrich
2016-09-16 7:47 ` [PATCH v2 1/3] state: copy backend of_path string Sascha Hauer
2016-09-16 8:12 ` Antony Pavlov [this message]
2016-09-21 7:52 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916111243.1dc2a3f16421fb33831817a0@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=m.olbrich@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox