From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] environment: "wrong magic" give the impression of an error
Date: Thu, 22 Sep 2016 10:08:39 +0200 [thread overview]
Message-ID: <20160922080839.ypjpltpcdsyjmle5@pengutronix.de> (raw)
In-Reply-To: <20160922050041.GA12923@ravnborg.org>
Hi Sam,
On Thu, Sep 22, 2016 at 07:00:41AM +0200, Sam Ravnborg wrote:
> From 144e3252f9604e44c48f90735489611f636e3e36 Mon Sep 17 00:00:00 2001
> From: Sam Ravnborg <srn@skov.dk>
> Date: Thu, 22 Sep 2016 06:54:42 +0200
> Subject: [PATCH 1/1] environment: "wrong magic" give the impression of an
> error
>
> Introduce a more soft wording when the magic of
> the superblock does not match.
> Include a hint to the typical reason "(envfs never written?)"
>
> This prevents a "what is wrong?" moment when looking at
> the boot log.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> common/environment.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/environment.c b/common/environment.c
> index db127d7..e0dfc12 100644
> --- a/common/environment.c
> +++ b/common/environment.c
> @@ -382,7 +382,7 @@ EXPORT_SYMBOL(envfs_save);
> static int envfs_check_super(struct envfs_super *super, size_t *size)
> {
> if (ENVFS_32(super->magic) != ENVFS_MAGIC) {
> - printf("envfs: wrong magic\n");
> + printf("envfs: no envfs (magic mismatch) - envfs newer written?\n");
When the super block cannot be found it could indeed be that an envfs
was never written,...
> return -EIO;
> }
>
> @@ -436,7 +436,7 @@ static int envfs_load_data(struct envfs_super *super, void *buf, size_t size,
> buf += sizeof(struct envfs_inode);
>
> if (ENVFS_32(inode->magic) != ENVFS_INODE_MAGIC) {
> - printf("envfs: wrong magic\n");
> + printf("envfs: no envfs (magic mismatch) - envfs newer written?\n");
... but when the super block is fine then a failure to read the data is
really that - a failure, no?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-09-22 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 5:00 Sam Ravnborg
2016-09-22 8:08 ` Sascha Hauer [this message]
2016-09-22 19:16 ` [PATCH v2] environment: "wrong magic" gives " Sam Ravnborg
2016-09-26 6:05 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922080839.ypjpltpcdsyjmle5@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox